[issue39666] IDLE: Factor out similar code in editor and hyperparser

[Cheryl Sabella]

Cheryl Sabella  added the comment:

PR20847 is an implementation with the parser function in hyperparser instead of 
EditorWindow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39666] IDLE: Factor out similar code in editor and hyperparser

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +20040
pull_request: https://github.com/python/cpython/pull/20847

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39666] IDLE: Factor out similar code in editor and hyperparser

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The quote from #32989 is from my msg313179, msg313179.

There are two levels of duplication.  First, between Hyperparser and 
EditorWindow.  Second between editor and shell branches.  While I said before 
to resolve the first with an EditorWindow method, as done in the patch, a 
hyperparser function, with 'self' replaced by 'editwin' would be possible.  I 
might prefer that.

The second level of duplication could be handled by a method in EditorWindow 
overridden by a method in PyShell.  But with duplication between the branches 
removed as in the patch, leaving the Shell branch so short, this does not seem 
as worthwhile.  I suspect/expect it would be even less so after future Shell 
changes.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39666] IDLE: Factor out similar code in editor and hyperparser

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +patch
pull_requests: +17916
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18539

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39666] IDLE: Factor out similar code in editor and hyperparser

[Cheryl Sabella]

New submission from Cheryl Sabella :

Under issue32989, there was discussion about refactoring duplicate code between 
hyperparser and editor.

> Perhaps separate issue: the 'if use_ps1' statements in editor and 
> hyperparser, and a couple of lines before, is nearly identical, and could be 
> factored into a separate editor method that returns a parser instance ready 
> for analysis.  It could then be tested in isolation.  The method should 
> return a parser instance ready for analysis.

--
assignee: terry.reedy
components: IDLE
messages: 362153
nosy: cheryl.sabella, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Factor out similar code in editor and hyperparser
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com