[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

> Oh, and Victor, you should probably email python-dev to let everyone know you 
> requested this change and it's been made. Otherwise people may be surprised 
> that it changed without any discussion or notification.

I wanted to wait until the situation was being clarified. I fixed the 
"documentation only" issue in GitHub Action workflow. I sent an email to 
python-committers rather than python-dev, core devs are the first concerned by 
workflow changes:

https://mail.python.org/archives/list/python-committ...@python.org/thread/B6WVI254L7GEOCKUOHZ6XBZD4GCLAIBV/

Slowly, it seems like the situation is being resolved.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

I created a follow-up issue to have again a mandatory Windows pre-commit CI: 
bpo-40548.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Brett Cannon]

Brett Cannon  added the comment:

> Can't we be more flexible depending on the stability on CIs over the last 
> weeks?

No because I'm tired of flipping CI on and off as mandatory based on the whims 
of CI systems and their stability. Either people need to accept CI is flaky or 
everyone needs to be careful in how they merge PRs by checking failures are 
legit.

And that's why I flipped off Azure Pipelines: I am not changing any more branch 
protections until a full discussion is had somewhere and there's consensus on 
what should be mandatory and stay mandatory for several months barring 
emergencies.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

Me:
> macOS was already non-voting (optional), no?

Steve:
> Only because you complained about it here :) That was PR 18818

Alright, I forgot about the whole history. Well, it's not my fault if macOS 
decided to fail :-)

I did my part, I fixed os.getgrouplist() which started (!?) to fail on the 
macOS job of Azure (in fact, it was an old issue which wasn't noticed 
previously): https://bugs.python.org/issue40014

I'm not sure what to do with macOS job which never starts or fail with empty 
logs. I don't see what we can do on the Python side. It *seems* to be more on 
the Azure side which is a blackbox to me. Maybe Steve you may ask around you at 
Microsoft? If you feel that you can do something to unblock the situation, 
please open an issue.

Note: I would also prefer to have a voting macOS job, but it's not like I can 
fix the macOS job myself, so I let others handle this one ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

I understood that such issue should be discussed in the Core Workflow category 
of Discourse, so I created:

"Make one Windows CI job mandatory"
https://discuss.python.org/t/make-one-windows-ci-job-mandatory/4047

I suggest to continue the discussion there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Steve Dower]

Steve Dower  added the comment:

> I'm not sure of what you mean by "no discussion", this issue has many 
> comments.

Let's say, no consensus. There were three votes cast in this discussion - yours 
(+1), mine (-1) and Brett's (I'll assume +0 because he made the change, despite 
saying he didn't want to ;) ).

Meanwhile, *everyone* is impacted, some people very negatively. The rest of the 
dev team need to know that it was a deliberate change.

> I would be more confident if we could make at least one Windows job mandatory.

Yes, so would I :)

> I don't know how to modify the Windows job to do nothing if it's a 
> documentation change only.

I can do it when I get time, but it's not very high on my list. I suggest 
looking at the Azure Pipelines definition, kind of like how I looked at the 
Travis definition to figure it out.

> macOS was already non-voting (optional), no?

Only because you complained about it here :) That was PR 18818

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Steve Dower]

Steve Dower  added the comment:

> FWIW, I took a quick look at it and, with nothing to go on in the way of 
> visible messages, the best guess I could come up with is that the test run 
> step is hitting a time out and that, in that case, no status is shown. Anyone 
> know if that is a reasonable guess?

I think it depends on the timeout. Some of my Ubuntu builds occasionally get 
hard-stuck on tkinter tests, so apparently it's possible for that to spoil CI. 
But I believe Pipelines is going to try and terminate the process "nicely" 
first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

Steve:
> Requests to change the workflow should be discussed on one of the 
> core-workflow groups (I think Discourse is the primary one now, right?). Once 
> an action is agreed upon, it gets tracked on the core-workflow tracker. 
> That's how we decided to turn Travis off and Azure Pipelines on in the first 
> place.

Ok.


> Oh, and Victor, you should probably email python-dev to let everyone know you 
> requested this change and it's been made. Otherwise people may be surprised 
> that it changed without any discussion or notification.

I'm not sure of what you mean by "no discussion", this issue has many comments.


> This is especially important if we have to disable all platforms other than 
> Linux to avoid blocking PRs.

I would be more confident if we could make at least one Windows job mandatory.

I have no opinion on msg363405, so I'm fine with Brett choice ("we have to just 
rely on people paying attention to failures").

I don't know how to modify the Windows job to do nothing if it's a 
documentation change only.

macOS was already non-voting (optional), no?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Ned Deily]

Ned Deily  added the comment:

> In the past, the macOS job was very reliable. I have no idea why it became so 
> flaky, but I don't have the bandwidth to investigate, moreover it seems like 
> some issues are internal to Azure Pipelines / GH Actions, and I don't have 
> access to these.

FWIW, I took a quick look at it and, with nothing to go on in the way of 
visible messages, the best guess I could come up with is that the test run step 
is hitting a time out and that, in that case, no status is shown. Anyone know 
if that is a reasonable guess?  The next question would be why are the tests 
taking that long on that macOS instance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

> Let's just hope that Travis has stabilised compared to when we switched away 
> from it, and maybe they have enough capacity now to handle our busy periods.

Can't we be more flexible depending on the stability on CIs over the last 
weeks? I mean making a CI optional if it becomes flaky, but also try to make a 
CI mandatory when it becomes stable.

In my experience, no CI is reliable and the stability varies a lot over time.

In the past, the macOS job was very reliable. I have no idea why it became so 
flaky, but I don't have the bandwidth to investigate, moreover it seems like 
some issues are internal to Azure Pipelines / GH Actions, and I don't have 
access to these.

I'm trying to do the best with my limited time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Steve Dower]

Steve Dower  added the comment:

Oh, and Victor, you should probably email python-dev to let everyone know you 
requested this change and it's been made. Otherwise people may be surprised 
that it changed without any discussion or notification.

This is especially important if we have to disable all platforms other than 
Linux to avoid blocking PRs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Steve Dower]

Steve Dower  added the comment:

Bugs in Python should continue to be reported here.

Requests to change the workflow should be discussed on one of the core-workflow 
groups (I think Discourse is the primary one now, right?). Once an action is 
agreed upon, it gets tracked on the core-workflow tracker. That's how we 
decided to turn Travis off and Azure Pipelines on in the first place.

Let's just hope that Travis has stabilised compared to when we switched away 
from it, and maybe they have enough capacity now to handle our busy periods.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

> Done.

Thanks.

> You will need to check that miss-islington doesn't solely rely on required 
> checks passing but instead all CI checks passing, otherwise this just turned 
> off gating for PRs when auto-merging.

I have no idea how miss-islington check CIs.

> And I'm going to say future requests for this sort of stuff should happen on 
> either on the core-workflow issue tracker or on discuss.python.org for better 
> visibility.

I'm used to report buildbot failures on bugs.python.org. Almost all issues are 
Python bugs, rather than issues specific to buidbot themselves.

I'm fine with reporting Azure Pipeline issues at core-workflow.

I created https://github.com/python/core-workflow/issues/365 " Make Travis CI 
(and Windows x64 ?) mandatory" :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Brett Cannon]

Brett Cannon  added the comment:

Done. You will need to check that miss-islington doesn't solely rely on 
required checks passing but instead all CI checks passing, otherwise this just 
turned off gating for PRs when auto-merging.

And I'm going to say future requests for this sort of stuff should happen on 
either on the core-workflow issue tracker or on discuss.python.org for better 
visibility.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

STINNER Victor  added the comment:

> Otherwise there were so many posts I didn't find an explicit ask of what you 
> wanted changed, Victor.

I would like to make Azure Pipelines optional on GitHub PRs.

I changed the issue title to make my request more explicit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[Brett Cannon]

Brett Cannon  added the comment:

Best place to report workflow issues or to have discussions about it is 
https://github.com/python/core-workflow/. Otherwise there were so many posts I 
didn't find an explicit ask of what you wanted changed, Victor.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39837] Make Azure Pipelines optional on GitHub PRs

[STINNER Victor]

Change by STINNER Victor :


--
title: Remove Azure Pipelines from GitHub PRs -> Make Azure Pipelines optional 
on GitHub PRs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com