[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 2b5603140c09766a7d4e8243a70d7144f684f6f9 by Serhiy Storchaka in 
branch 'master':
bpo-40178: Convert the remaining os functions to Argument Clinic. (GH-19360)
https://github.com/python/cpython/commit/2b5603140c09766a7d4e8243a70d7144f684f6f9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#37206 changed the signature "pop(self, key, default=None, /)" back to 
"D.pop(k[,d]) -> v", taken from dict.pop.__doc__.  However, the incorrect 
version that got reverted correctly added the positional-only indicator '/'.  
Docstrings with signatures for such cases may need updating.

Unlike most objects with invalid signatures (as seen by inspect.signature), the 
current docstring for os.get_terminal_size does not have a backup signature for 
help (and IDLE) to present.  I cannot tell if the patch adds it.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +Argument Clinic
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The problems which prevented their conversions before (in issue20170):

1. os.sendfile() had parameter names conflicting with Python keywords. Was 
solved in issue38378.

2. os.get_terminal_size() has an optional argument without default value. It 
was solved in a way similar to issue37206.

3. Some functions have platform-specific types of arguments. os.sendfile() has 
additional parameters. It was solved by using a preprocessor. We need to repeat 
most of the declaration and docstring, but it is the best that we can have now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +18722
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19360

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40178] Convert the remaining os funtions to Argument Clinic

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

The proposed PR converts os.getgrouplist(), os.initgroups(), os.sendfile() and 
os.get_terminal_size() to Argument Clinic.

--
components: Extension Modules
messages: 365762
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: Convert the remaining os funtions to Argument Clinic
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com