[issue40297] test_socket.CANTest is broken at HEAD on master

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests:  -25776

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal
nosy_count: 5.0 -> 6.0
pull_requests: +25776
pull_request: https://github.com/python/cpython/pull/27228

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Ned Deily]

Ned Deily  added the comment:


New changeset 1beae7e523d2db4e3ce383b2032095ef956f21c4 by Zachary Ware in 
branch '3.7':
[3.7] bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-25960)
https://github.com/python/cpython/commit/1beae7e523d2db4e3ce383b2032095ef956f21c4


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 8a12f46dd8c780de84d78e6dd8350230e52e0c46 by Miss Islington (bot) 
in branch '3.8':
bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548) (#25957)
https://github.com/python/cpython/commit/8a12f46dd8c780de84d78e6dd8350230e52e0c46


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Zachary Ware]

Change by Zachary Ware :


--
pull_requests: +24619
pull_request: https://github.com/python/cpython/pull/25960

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Zachary Ware]

Change by Zachary Ware :


--
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[miss-islington]

Change by miss-islington :


--
pull_requests: +24618
pull_request: https://github.com/python/cpython/pull/25957

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Zachary Ware]

Zachary Ware  added the comment:

Thanks for the thoroughly researched patch and your patience!  Sorry it took so 
long to get it merged.

--
nosy: +zach.ware
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[miss-islington]

miss-islington  added the comment:


New changeset df99532a05e4cfba8d9835375d4a3830b84472ad by Miss Islington (bot) 
in branch '3.9':
bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548)
https://github.com/python/cpython/commit/df99532a05e4cfba8d9835375d4a3830b84472ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[miss-islington]

miss-islington  added the comment:


New changeset 7b4725a210bcfe3dc65f37cbada423cbd1e9f063 by Miss Islington (bot) 
in branch '3.10':
bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548)
https://github.com/python/cpython/commit/7b4725a210bcfe3dc65f37cbada423cbd1e9f063


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[miss-islington]

Change by miss-islington :


--
pull_requests: +24571
pull_request: https://github.com/python/cpython/pull/25903

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 1.0 -> 2.0
pull_requests: +24570
pull_request: https://github.com/python/cpython/pull/25902

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Karl Ding]

Karl Ding  added the comment:

Related: I've started a thread on Discourse [0] looking into why the tests 
don't seem to be run on the Buildbot cluster (and what it would take to enable 
them). Hopefully it gains some traction.

[0] 
https://discuss.python.org/t/what-would-it-take-to-run-socketcan-tests-on-a-buildbot/4137

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Karl Ding]

Change by Karl Ding :


--
keywords: +patch
pull_requests: +18894
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19548

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40297] test_socket.CANTest is broken at HEAD on master

[Karl Ding]

New submission from Karl Ding :

While working on https://bugs.python.org/issue40291, I was trying to run the 
SocketCAN tests to ensure that my changes weren't causing any regressions. 
However, I was seeing test failures at HEAD.

I'm running the tests like so:

# Kernel version
uname -r
# 5.4.23-1-MANJARO

# Load SocketCAN vcan kernel module
sudo modprobe vcan

# Start and set up a virtual SocketCAN interface
sudo ip link add dev vcan0 type vcan
sudo ip link set up vcan0

# Run the socket tests using locally built python
./python -m unittest -v test.test_socket.CANTest

After bisecting, I discovered that the test started failing back in 2017, with 
the introduction of the ISOTP protocol. 
https://github.com/python/cpython/pull/2956/files#diff-a47fd74731aeb547ad780900bb8e6953L1376-R1391

Here, the address family (the second tuple item) is explicitly removed:

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index bf8d19fe2f..beadecfad5 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -1373,9 +1373,22 @@ makesockaddr(SOCKET_T sockfd, struct sockaddr *addr, 
size_t addrlen, int proto)
 ifname = ifr.ifr_name;
 }

-return Py_BuildValue("O", PyUnicode_DecodeFSDefault,
-ifname,
-a->can_family);
+switch (proto) {
+#ifdef CAN_ISOTP
+  case CAN_ISOTP:
+  {
+  return Py_BuildValue("O", PyUnicode_DecodeFSDefault,
+  ifname,
+  a->can_addr.tp.rx_id,
+  a->can_addr.tp.tx_id);
+  }
+#endif
+  default:
+  {
+  return Py_BuildValue("O&", PyUnicode_DecodeFSDefault,
+ifname);
+  }
+}
 }
 #endif

This seems to be an intentional breakage, since the code in getsockaddrarg also 
operates on just the interface name, ignoring the address family.

if (!PyArg_ParseTuple(args,
  "O&;AF_CAN address must be a tuple "
  "(interface, )",
  PyUnicode_FSConverter, ))

As such, I believe the test should have been updated, but was missed during the 
ISOTP changes. Can someone (a core member?) confirm that this is the correct 
approach?

Note: However, this also implies that the CANTest test was never being run 
(either via CI on PRs or on the Buildbot cluster) and instead was always 
skipped, since I would've expected this failure to show up right away...

--
components: Library (Lib)
messages: 366576
nosy: karlding
priority: normal
severity: normal
status: open
title: test_socket.CANTest is broken at HEAD on master
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com