[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread Robert Rouhani 


Robert Rouhani  added the comment:

No problem! Happy to contribute where I can :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread Brett Cannon 


Brett Cannon  added the comment:

Thanks for all your hard work, Robert!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread miss-islington 


miss-islington  added the comment:


New changeset d64fd617e02346ecbcba9559f227936e08e89602 by Robert Rouhani in 
branch '3.7':
[3.7] bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750) 
(GH-19935)
https://github.com/python/cpython/commit/d64fd617e02346ecbcba9559f227936e08e89602


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread miss-islington 


miss-islington  added the comment:


New changeset a32587a60da5939a3932bb30432d2bdd3d6203d4 by Robert Rouhani in 
branch '3.8':
[3.8] bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750) 
(GH-19934)
https://github.com/python/cpython/commit/a32587a60da5939a3932bb30432d2bdd3d6203d4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread Robert Rouhani 


Change by Robert Rouhani :


--
pull_requests: +19250
pull_request: https://github.com/python/cpython/pull/19935

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-05 Thread Robert Rouhani 


Change by Robert Rouhani :


--
pull_requests: +19249
pull_request: https://github.com/python/cpython/pull/19934

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-04 Thread Brett Cannon 


Brett Cannon  added the comment:

This can't be backported cleanly. If you're up for making PRs for 3.8 and 3.7, 
Robert, we can look at applying them.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-04 Thread Brett Cannon 


Change by Brett Cannon :


--
versions:  -Python 3.5, Python 3.6, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-01 Thread miss-islington 


miss-islington  added the comment:


New changeset f40bd466bf14029e2687e36e965875adf9d4be1a by Robert Rouhani in 
branch 'master':
bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750)
https://github.com/python/cpython/commit/f40bd466bf14029e2687e36e965875adf9d4be1a


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-01 Thread Robert Rouhani 


Robert Rouhani  added the comment:

We have a fairly straightforward workaround of using the "warnings" module
to redirect to stdout, so we personally don't have a need.

Unreal, however, follows the VFX Reference Platform (
https://vfxplatform.com/) which is migrating from 2.7 to 3.7.x this year.
They will likely run into this during their migration, so backporting to
3.7 would be useful.

On Fri, May 1, 2020 at 8:22 AM Eric Snow  wrote:

>
> Eric Snow  added the comment:
>
> Did you have a need for this to be fixed in 3.8 or earlier?  This seems
> reasonably and simple enough to backport.  I suppose someone could be
> relying on an implicit import of the "imp" module, but that seems highly
> unlikely and suspect anyway. :)
>
> --
> nosy: +brett.cannon, ncoghlan
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-01 Thread Eric Snow 


Eric Snow  added the comment:

Did you have a need for this to be fixed in 3.8 or earlier?  This seems 
reasonably and simple enough to backport.  I suppose someone could be relying 
on an implicit import of the "imp" module, but that seems highly unlikely and 
suspect anyway. :)

--
nosy: +brett.cannon, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-05-01 Thread Eric Snow 


Eric Snow  added the comment:

Yeah, that looks like an oversight.  I've approved your PR.  Thanks!

--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-04-28 Thread Roundup Robot 


Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +19071
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19750

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40417] PyImport_ReloadModule emits deprecation warning

2020-04-28 Thread Robert Rouhani 


New submission from Robert Rouhani :

It appears as though PyImport_ReloadModule is importing the deprecated "imp" 
module.

I integrated a newer version of Python into Unreal Engine 4, which internally 
calls this function for some of it's own modules. Normally a stray warning 
wouldn't be of much concern to me, but the process of "cooking" (converting raw 
assets to optimized/final assets) will fail if anything is written to stderr. 
This makes it impossible to package a copy of the game for testing or release 
without a workaround.

I'm going to add a test to _testembed.c to verify my fix. Is this something 
that I should include in the Github PR?

--
components: Interpreter Core
messages: 367501
nosy: Robert Rouhani
priority: normal
severity: normal
status: open
title: PyImport_ReloadModule emits deprecation warning
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com