[issue40458] test_attribute_name_interning crashes on APPX test

[Steve Dower]

Steve Dower  added the comment:

Turns out the stack reservation was different, which is why it was crashing.

As part of diagnosing it, I added the recursion count to faulthandler's output 
on Windows, but couldn't see if/where to do it for other platforms - Victor, 
any suggestions?

--
nosy: +vstinner
type:  -> crash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40458] test_attribute_name_interning crashes on APPX test

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +19163
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19845

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40458] test_attribute_name_interning crashes on APPX test

[Steve Dower]

New submission from Steve Dower :

The Windows CI machines on Azure Pipelines run additional tests to check an 
"installed" layout and with the UWP entry point that's used for the Windows 
Store package.

These tests have been failing intermittently (though regularly) with a stack 
overflow crash in the PyPickler tests.

Example: 
https://dev.azure.com/Python/cpython/_build/results?buildId=62055&view=results

test_attribute_name_interning (test.test_pickle.PyPicklerTests) ... ok
  File "D:\a\1\b\layout-appx-amd64\lib\test\pickletester.py", line 3085 in 
__getattr__
  File "D:\a\1\b\layout-appx-amd64\lib\test\pickletester.py", line 3085 in 
__getattr__
  File "D:\a\1\b\layout-appx-amd64\lib\test\pickletester.py", line 3085 in 
__getattr__
  File "D:\a\1\b\layout-appx-amd64\lib\test\pickletester.py", line 3085 in 
__getattr__
...

I assume this is due to having more code on the start at the start, and so the 
recursion limit isn't low enough. But it might also be worth checking this 
particular case to see whether there is unnecessary data being kept on the 
stack (e.g. in local C variables).

The crash occurs in both 3.8 and master, but not 3.7.

--
components: Windows
messages: 367803
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: test_attribute_name_interning crashes on APPX test
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com