[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Berker Peksag]

Change by Berker Peksag :


--
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Berker Peksag]

Berker Peksag  added the comment:

I think this is now done. Thank you, Erlend!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Berker Peksag]

Berker Peksag  added the comment:


New changeset cf0b23908cc902ac38cd83dd7ca5afdf89e1543b by Erlend Egeberg 
Aasland in branch 'master':
bpo-40810: Require SQLite 3.7.15 (GH-24106)
https://github.com/python/cpython/commit/cf0b23908cc902ac38cd83dd7ca5afdf89e1543b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Cheryl Sabella]

Change by Cheryl Sabella :


--
nosy: +cheryl.sabella
nosy_count: 7.0 -> 8.0
pull_requests: +22942
pull_request: https://github.com/python/cpython/pull/14491

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +22941
pull_request: https://github.com/python/cpython/pull/24112

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +22940
pull_request: https://github.com/python/cpython/pull/24111

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Brandt Bucher]

Brandt Bucher  added the comment:

It looks like the markup in the NEWS entry broke Travis on master. I guess 
that's one downside of Travis not being a required job anymore.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Brandt Bucher]

Change by Brandt Bucher :


--
nosy: +brandtbucher
nosy_count: 6.0 -> 7.0
pull_requests: +22939
pull_request: https://github.com/python/cpython/pull/24110

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

miss-islington  added the comment:


New changeset 80e5732d31bb7362c7b647acc618df701b3ae951 by Miss Islington (bot) 
in branch '3.9':
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (GH-20530)
https://github.com/python/cpython/commit/80e5732d31bb7362c7b647acc618df701b3ae951


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

miss-islington  added the comment:


New changeset 0ccac5ff587d7637854e5d3e75f0f9a8f5528e59 by Miss Islington (bot) 
in branch '3.8':
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (GH-20530)
https://github.com/python/cpython/commit/0ccac5ff587d7637854e5d3e75f0f9a8f5528e59


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

> +1 for dropping support for < 3.7.15 in master. We should fix or skip tests 
> in maintenance branches.

PR's for fixing the tests in 3.9 and 3.8 are now awaiting merge. PR for 
dropping support for SQLite pre 3.7.15 in master is opened.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +22935
pull_request: https://github.com/python/cpython/pull/24106

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Guido van Rossum]

Guido van Rossum  added the comment:

Please ping this issue if the backports don't auto-merge after the tests pass, 
or if the tests fail.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +22934
pull_request: https://github.com/python/cpython/pull/24105

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +22933
pull_request: https://github.com/python/cpython/pull/24104

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[miss-islington]

miss-islington  added the comment:


New changeset f7f0ed59bcc41ed20674d4b2aa443d3b79e725f4 by Erlend Egeberg 
Aasland in branch 'master':
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 (GH-20530)
https://github.com/python/cpython/commit/f7f0ed59bcc41ed20674d4b2aa443d3b79e725f4


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +19774
pull_request: https://github.com/python/cpython/pull/20530

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

FYI, the #if in line 1563 in `Modules/_sqlite/connection.c` is wrong, but the 
comment five lines below is correct:
https://github.com/python/cpython/blob/e56ce3ce865cb5539cdedbeae54eaa11ec563922/Modules/_sqlite/connection.c#L1563-L1589

`sqlite3_errstr()` was introduced in 3.7.15, so the #if comparison operator 
should have been '>=', not '>'.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +19753
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/20330

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

All right, will do, Berker Persag.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Berker Peksag]

Berker Peksag  added the comment:

+1 for dropping support for < 3.7.15 in master. We should fix or skip tests in 
maintenance branches.

--
stage:  -> needs patch
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Debian oldstable (jessie) has sqlite 3.8.7.1
Ubuntu 14.04 LTS (trusty) has sqlite 3.8.2
CentOS 7 and 8 has sqlite versions > 3.7.15

The following distributions include sqlite version _less than_ 3.7.15:
• Porteus (release v2.1 and older)
• OLPC OS
• HardenedBSD
• 0Linux / FreePBX (release v10 and older)
• ToOpPy Linux
• Baruwa Enterprise Edition

The other hits were inactive distros.

https://distrowatch.com/search.php?pkg=sqlite=less=3.7.15=InLatest#pkgsearch

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Christian Heimes]

Christian Heimes  added the comment:

Could you please check https://distrowatch.com/ and verify that all major Linux 
distributions have a sufficient version of sqlite. Please also check LTS like 
Debian oldstable, Ubuntu, and CentOS.

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Also related to bpo-26187

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40810] sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 3.7.14.1

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

`CheckTraceCallbackContent()` in `Lib/sqlite3/test/hooks.py` fails for SQLite 
versions 3.7.3 through 3.7.14.1, apparently because of an SQLite bug that was 
fixed in 3.7.15 (2012-12-12). Extract from the changelog 
https://sqlite.org/changes.html:
```
Avoid invoking the sqlite3_trace() callback multiple times when a statement is 
automatically reprepared due to SQLITE_SCHEMA errors.
```

Either we fix tests for SQLite < 3.7.15, or we drop support for SQLite < 
3.7.15. (I'm +1 for the latter.)

NB: Versions pre 3.7.3 does not build at all, because of 
`sqlite3_create_function_v2()`. See bpo-40744 and GH-20330.

--
components: Library (Lib)
messages: 370256
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: sqlite3 test CheckTraceCallbackContent fails for sqlite v3.7.3 through 
3.7.14.1
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com