[issue41158] IDLE: rewrite the code for handling file encoding

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#41300 reports that the new iomenu line 291
   enc, _ = tokenize.detect_encoding(io.BytesIO(encoded).readline)
fails without 'import io' added.  I should have tested more thoroughly.  I will 
fix and add tests there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[miss-islington]

miss-islington  added the comment:


New changeset c3fa7534c7173d338880a1727f17795670518610 by Miss Islington (bot) 
in branch '3.8':
bpo-41158: IDLE: rewrite the code for handling file encoding (GH-21215)
https://github.com/python/cpython/commit/c3fa7534c7173d338880a1727f17795670518610


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[miss-islington]

Change by miss-islington :


--
pull_requests: +20416
pull_request: https://github.com/python/cpython/pull/21267

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[miss-islington]

miss-islington  added the comment:


New changeset fe0175f5b50967aae90cb759a0d2d016fb745584 by Miss Islington (bot) 
in branch '3.9':
bpo-41158: IDLE: rewrite the code for handling file encoding (GH-21215)
https://github.com/python/cpython/commit/fe0175f5b50967aae90cb759a0d2d016fb745584


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[miss-islington]

Change by miss-islington :


--
pull_requests: +20408
pull_request: https://github.com/python/cpython/pull/21260

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +20407
pull_request: https://github.com/python/cpython/pull/21259

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

No, it can be backported to 3.8 and 3.9 if you wish.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Is there any reason the patch would not work with 3.9/3.8?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 694d31e714074176f0c324f95948b75dc768c091 by Serhiy Storchaka in 
branch 'master':
bpo-41158: IDLE: rewrite the code for handling file encoding (GH-21215)
https://github.com/python/cpython/commit/694d31e714074176f0c324f95948b75dc768c091


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +20368
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21215

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41158] IDLE: rewrite the code for handling file encoding

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

The proposed patch rewrites the code in IDLE for detecting Python file encoding 
and decoding and encoding Python sources by using the tokenize module instead 
of handmade implementation of PEP 263.

--
assignee: terry.reedy
components: IDLE
messages: 372563
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: rewrite the code for handling file encoding
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com