[issue41246] IOCP Proactor same socket overlapped callbacks

[Jim Jewett]

Change by Jim Jewett :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41246] IOCP Proactor same socket overlapped callbacks

[Tony]

Tony  added the comment:

bump

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41246] IOCP Proactor same socket overlapped callbacks

[Tony]

Tony  added the comment:

I feel like the metadata is not really a concern here. I like when there is no 
code duplication :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41246] IOCP Proactor same socket overlapped callbacks

[Jim Jewett]

Jim Jewett  added the comment:

Looks good to me.  

I at first worried that the different function names were useful metadata that 
was getting lost -- but the names were already duplicated in several cases.  
*If* that is still a concern for the committer, then instead of repeating the 
code (as current production does), each section should just say 
newname=origname before registering the static method (as the patch does), and 
should bind a distinct name for each usage.

--
nosy: +Jim.Jewett
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41246] IOCP Proactor same socket overlapped callbacks

[Tony]

Change by Tony :


--
keywords: +patch
pull_requests: +20547
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21399

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41246] IOCP Proactor same socket overlapped callbacks

[Tony]

New submission from Tony :

In IocpProactor I saw that the callbacks to the functions recv, recv_into, 
recvfrom, sendto, send and sendfile all give the same callback function for 
when the overlapped operation is done.

I just wanted cleaner code so I made a static function inside the class that I 
give to each of these functions as the overlapped callbacks.

--
messages: 373324
nosy: tontinton
priority: normal
severity: normal
status: open
title: IOCP Proactor same socket overlapped callbacks

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com