[issue41366] sign-conversion warning in 3.9 beta

[Inada Naoki]

Inada Naoki  added the comment:

Thank you.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41366] sign-conversion warning in 3.9 beta

[miss-islington]

miss-islington  added the comment:


New changeset e8dda907fbeb957436d2662714d993b073be55bb by Miss Islington (bot) 
in branch '3.9':
bpo-41366: Fix clang warning for sign conversion (GH-21592)
https://github.com/python/cpython/commit/e8dda907fbeb957436d2662714d993b073be55bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41366] sign-conversion warning in 3.9 beta

[Inada Naoki]

Inada Naoki  added the comment:


New changeset 680254a8dc64e3ada00f88a7c42d41eb02108353 by Henry Schreiner in 
branch 'master':
bpo-41366: Fix clang warning for sign conversion (GH-21592)
https://github.com/python/cpython/commit/680254a8dc64e3ada00f88a7c42d41eb02108353


--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41366] sign-conversion warning in 3.9 beta

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +20739
pull_request: https://github.com/python/cpython/pull/21600

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41366] sign-conversion warning in 3.9 beta

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +20731
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21592

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41366] sign-conversion warning in 3.9 beta

[Henry Schreiner]

New submission from Henry Schreiner :

The macro Py_UNICODE_COPY was replaced by a function in CPython 3.9, and that 
function cannot compile with full warnings enabled + warnings as errors under 
Clang. The problematic line:

Py_DEPRECATED(3.3) static inline void
Py_UNICODE_COPY(Py_UNICODE *target, const Py_UNICODE *source, Py_ssize_t 
length) {
memcpy(target, source, length * sizeof(Py_UNICODE));
}

has an implicit conversion of Py_ssize_t into size_t, which creates:

/Users/runner/hostedtoolcache/Python/3.9.0-beta.5/x64/include/python3.9/cpython/unicodeobject.h:55::
 implicit conversion changes signedness: 'Py_ssize_t' (aka 'long') to 'unsigned 
long' [-Werror,-Wsign-conversion]

error: implicit conversion changes signedness: 'Py_ssize_t' (aka 'long') to 
'unsigned long' [-Werror,-Wsign-conversion]
memcpy(target, source, length * sizeof(Py_UNICODE));memcpy(target, 
source, length * sizeof(Py_UNICODE));

An explicit cast to size_t (is there a Py_size_t?) should be made.

--
components: C API
messages: 374084
nosy: Henry Schreiner
priority: normal
severity: normal
status: open
title: sign-conversion warning in 3.9 beta
type: compile error
versions: Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com