[issue41391] Make test_unicodedata pass when running without network

[Chih-Hsuan Yen]

Chih-Hsuan Yen  added the comment:

Closing in favor of a simpler fix merged from issue43144. Thanks for the fix!

--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41391] Make test_unicodedata pass when running without network

[Jim Jewett]

Jim Jewett  added the comment:

Looks Good To Me

--
nosy: +Jim.Jewett

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41391] Make test_unicodedata pass when running without network

[Chih-Hsuan Yen]

Change by Chih-Hsuan Yen :


--
keywords: +patch
pull_requests: +20757
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21615

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41391] Make test_unicodedata pass when running without network

[Chih-Hsuan Yen]

New submission from Chih-Hsuan Yen :

I setup a buildbot worker to test Python 3.x on Android monthly. This month 
network in the Android emulator is broken and I got an additional test failure:

0:05:28 load avg: 1.21 [376/423/11] test_unicodedata failed
test test_unicodedata failed -- Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/urllib/request.py", line 1342, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
socket.gaierror: [Errno 7] No address associated with hostname

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/test/test_unicodedata.py", line 329, in 
test_normalization
testdata = open_urlresource(TESTDATAURL, encoding="utf-8",
urllib.error.URLError: 

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/local/tmp/lib/python3.10/test/test_unicodedata.py", line 335, in 
test_normalization
self.fail(f"Could not retrieve {TESTDATAURL}")
AssertionError: Could not retrieve 
http://www.pythontest.net/unicode/13.0.0/NormalizationTest.txt

I propose wrapping the test in socket_helper.transient_internet() so that this 
test is skipped if the Internet is not available.

--
components: Tests
messages: 374249
nosy: yan12125
priority: normal
severity: normal
status: open
title: Make test_unicodedata pass when running without network
type: behavior
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com