[issue4151] Separate build dir broken
Éric Araujo mer...@netwok.org added the comment: For the record, I’m not clear about what is fixed or not in each branch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Éric Araujo mer...@netwok.org added the comment: I think so too. -- assignee: nascheme - mwh nosy: +mwh resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer nas-pyt...@arctrix.com added the comment: I believe the latest problem reported has been fixed by SVN rev 80649. -- assignee: - nascheme nosy: -nas stage: - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Changes by Éric Araujo mer...@netwok.org: -- nosy: +merwok ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Matthias Klose d...@debian.org added the comment: current status with 2.7 alpha3: FAIL: test_get_python_inc (distutils.tests.test_sysconfig.SysconfigTestCase) -- Traceback (most recent call last): File /home/packages/python/2.7/python2.7-2.7~a3/Lib/distutils/tests/test_sysconfig.py, line 47, in test_get_python_inc self.assertTrue(os.path.isfile(python_h), python_h) AssertionError: /home/packages/python/2.7/python2.7-2.7~a3/build-static/Include/Python.h unsure about this one: FAIL: test_finalize_options (distutils.tests.test_build.BuildTestCase) -- Traceback (most recent call last): File /home/packages/python/2.7/python2.7-2.7~a3/Lib/distutils/tests/test_build.py, line 24, in test_finalize_options self.assertEquals(cmd.build_purelib, wanted) AssertionError: 'build/lib.linux-i686-2.7' != 'build/lib' -- nosy: +tarek versions: +Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Andy Buckley a...@insectnation.org added the comment: I'm having trouble with this as well :( It's pretty much a blocker for integrating distutils-based extension builds with an autotools library build, because the make distcheck target explicitly does the build in a subtree of the source directory, and write-protects the srcdir during the build. Effectively the source is referred to in my setup.py as living in ../../pyext, which translates into distutils attempting to build the extension in build/temp.linux-i686-2.5/../../pyext/, which is the write-protected source dir. This would work okay if the directory path to the source file were ignored when constructing the output path: would the proposed patch(es) fix this? -- nosy: +andybuckley ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Roumen Petrov bugtr...@roumenpetrov.info added the comment: One additional commit change srcdir = os.path.normpath(srcdir) to srcdir = os.path.abspath(srcdir) and this should not create relative path. In this case I expect build in directory build/temp.PLATFORM_VERSION/ABS_SRC_PATH. Andi, did above change work for you. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Matthias Klose d...@debian.org added the comment: still seen on the 2.6 branch. applying r69374 on the branch doesn't fix it there. -- nosy: +doko resolution: fixed - status: closed - open versions: +Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer nas-pyt...@arctrix.com added the comment: On Thu, Feb 12, 2009 at 01:32:37PM +, Matthias Klose wrote: still seen on the 2.6 branch. applying r69374 on the branch doesn't fix it there. The fix is spread over a number of commits: r69374, r69322, r69315, r69305, r69304, r69303, r69302. It could be backported but changing the build system is always fraught with portability traps and that's why it ends up turning to crud over time. Obviously most core Python developers don't build in a separate directory otherwise this feature won't have been broken for so long. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer nas-pythonb...@arctrix.com added the comment: I committed my proposed changes in several chunks, ending with r69305. I think building in a separate directory again works and that non-POSIX platforms are not adversely affected by this change. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer nas-pyt...@arctrix.com added the comment: I committed my proposed changes in several chunks, ending with r69305. I think building in a separate directory again works and that non-POSIX platforms are not adversely affected by this change. -- nosy: +nascheme resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Changes by Neil Schemenauer nas-pyt...@arctrix.com: ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Roumen Petrov bugtr...@roumenpetrov.info added the comment: May be not related to the commit but after clean make fail to build a number of modules, as example _bisect. Second run of make build all left. The value of srcdir (from Makefile) is .. without quotes. About cleanup: one use of '(srcdir,)==...' left in setup.py . ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Roumen Petrov bugtr...@roumenpetrov.info added the comment: The clean build' mean missing subdirectory build in builddir . Now module objects go in build/Modules/. I guess that second make succeed as libffi create build directory. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer nas-pyt...@arctrix.com added the comment: Roumen, thanks for reporting the bug. It seems that distutils requires an absolute path (although I didn't waste time digging too deep into the issue). ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Neil Schemenauer [EMAIL PROTECTED] added the comment:
[Roumen Petrov]
Modification for test_build_ext.py from above mentioned issue break
non-posix builds.
Without that change the test fails on Unix platforms when the build is
not done inside the source directory. I guess the problem must be the
change from (essentially):
def _get_source_filename():
return os.path.join(sysconfig.project_base, 'Modules', 'xxmodule.c')
to
def _get_source_filename():
srcdir = sysconfig.get_config_var('srcdir')
return os.path.join(srcdir, 'Modules', 'xxmodule.c')
On POSIX, project_base is just the directory containing the Python
executable. I think the right thing to do is to fix the srcdir var on
non-POSIX systems. I don't have a Windows machine to test on. Could
someone test the get_python_inc2.patch with the non_posix_srcdir.patch
applied on top of it?
Added file: http://bugs.python.org/file11858/non_posix_srcdir.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4151
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
New submission from Neil Schemenauer [EMAIL PROTECTED]: Building in a separate directory got broken at some point. The code is hairy but it looks like the source of the problem was a lame sysconfig.get_python_inc() function. The attached patches fix things and hopefully do not introduce any new bugs. -- components: Build files: get_python_inc.patch keywords: patch messages: 74996 nosy: nas severity: normal status: open title: Separate build dir broken type: compile error Added file: http://bugs.python.org/file11837/get_python_inc.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Changes by Neil Schemenauer [EMAIL PROTECTED]: Added file: http://bugs.python.org/file11838/get_python_inc2.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Changes by Neil Schemenauer [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file11837/get_python_inc.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4151] Separate build dir broken
Roumen Petrov [EMAIL PROTECTED] added the comment: get_python_inc() and test case is addressed in issue4070 as well. -- nosy: +rpetrov ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4151 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
