[issue41562] StreamReaderProtocol inheritance

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Fixing a non-broken thing is not a world-class idea, I think.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41562] StreamReaderProtocol inheritance

[Dan Pascu]

Dan Pascu  added the comment:

While it may not be affected at a functional level (at least not in a way I can 
see right now), it is confusing when reading that code.

Isn't clarity and avoiding confusion a desired trait for core python code?

What about all these recommendations from the Zen of Python?

Beautiful is better than ugly.
Simple is better than complex.
Flat is better than nested.
Readability counts.
If the implementation is hard to explain, it's a bad idea.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41562] StreamReaderProtocol inheritance

[Andrew Svetlov]

Andrew Svetlov  added the comment:

You are right, but the existing inheritance is also correct (while a little 
redundant).

Sorry, I don't think we should do anything: don't fix if not broken.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41562] StreamReaderProtocol inheritance

[Dan Pascu]

New submission from Dan Pascu :

I noticed that StreamReaderProtocol is defined like this:

class StreamReaderProtocol(FlowControlMixin, protocols.Protocol):
...

but FlowControlMixin already inherits protocols.Protocol:

class FlowControlMixin(protocols.Protocol):
...

It seems redundant that StreamReaderProtocol has protocols.Protocol as a second 
base class (is this an oversight or I'm missing some hidden reasoning behind it 
in which case it might be useful to have it mentioned in a comment to avoid 
confusion).

--
components: asyncio
messages: 375504
nosy: asvetlov, danpascu777, yselivanov
priority: normal
severity: normal
status: open
title: StreamReaderProtocol inheritance
type: enhancement
versions: Python 3.10, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com