[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread STINNER Victor 


STINNER Victor  added the comment:

Thanks Kumar for the fix!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 75d88b91e6b1320ae0511eaf72e860bea913a3eb by Miss Islington (bot) 
in branch '3.10':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving 
(GH-30845) (#30860)
https://github.com/python/cpython/commit/75d88b91e6b1320ae0511eaf72e860bea913a3eb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset f9ff0bf515e0fa162889aca508e755cc65d85079 by Miss Islington (bot) 
in branch '3.9':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving 
(GH-30845) (#30861)
https://github.com/python/cpython/commit/f9ff0bf515e0fa162889aca508e755cc65d85079


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +29072
pull_request: https://github.com/python/cpython/pull/30861

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +29071
pull_request: https://github.com/python/cpython/pull/30860

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-25 Thread STINNER Victor 


STINNER Victor  added the comment:

Test fixed on Windows 2022 by:

commit 1c705fda8f9902906edd26d46acb0433b0b098e1
Author: Kumar Aditya <59607654+kumaraditya...@users.noreply.github.com>
Date:   Tue Jan 25 02:34:47 2022 +0530

fixed flaky test (GH-30845)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-24 Thread Andrew Svetlov 


Andrew Svetlov  added the comment:

Guido, I can not confirm your suggestion but it seems correct to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-24 Thread Kumar Aditya 


Change by Kumar Aditya :


--
nosy: +kumaraditya303
nosy_count: 13.0 -> 14.0
pull_requests: +29027
pull_request: https://github.com/python/cpython/pull/30845

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-23 Thread Guido van Rossum 


Guido van Rossum  added the comment:

I'm wondering if the test is faulty. It seems to call EventLoop.sendfile() with 
a file that is 8K + 1 byte long,
and the protocol is instructed to close after 1K bytes have been written, but 
it seems to try to send as much of the file as it can.
Could it be that on Win22 the primitive used (TransmitFile) has an internal 
minimum buffer size that exceeds this file size, so the first call sends the 
whole file and there's no error?

@Andrew Svetlov, do you know enough of the internals of this code to validate 
my theory?

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread STINNER Victor 


Change by STINNER Victor :


--
pull_requests: +29006
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30817

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 486b4d3d8e1a5699a2854e310c58fe12b220b7a9 by Miss Islington (bot) 
in branch '3.10':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801) 
(GH-30812)
https://github.com/python/cpython/commit/486b4d3d8e1a5699a2854e310c58fe12b220b7a9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread Jason R. Coombs 


Change by Jason R. Coombs :


--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread miss-islington 


miss-islington  added the comment:


New changeset ba932d90244252f6d4073263f25989507a183f79 by Miss Islington (bot) 
in branch '3.9':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801)
https://github.com/python/cpython/commit/ba932d90244252f6d4073263f25989507a183f79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +29000
pull_request: https://github.com/python/cpython/pull/30812

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread miss-islington 


Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 11.0 -> 12.0
pull_requests: +28999
pull_request: https://github.com/python/cpython/pull/30811

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 1ded8ed8e817b8f9dae1a0ef92d97983afbc844e by Nikita Sobolev in 
branch 'main':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801)
https://github.com/python/cpython/commit/1ded8ed8e817b8f9dae1a0ef92d97983afbc844e


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread Erlend E. Aasland 


Erlend E. Aasland  added the comment:

Previously, this failure was more sporadic; now it happens almost every single 
run on the Azure CI. Has there been updates on the Azure CI lately?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread Oleg Iarygin 


Change by Oleg Iarygin :


--
nosy: +arhadthedev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2022-01-22 Thread Nikita Sobolev 


Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +28986
pull_request: https://github.com/python/cpython/pull/30801

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-12-15 Thread STINNER Victor 


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-12-15 Thread Ken Jin 


Ken Jin  added the comment:

Happened to a PR I was reviewing today:
https://github.com/python/cpython/runs/4535247255?check_suite_focus=true

--
keywords:  -patch
nosy: +kj
versions: +Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-10-22 Thread Erlend E. Aasland 


Erlend E. Aasland  added the comment:

New failure today: 
https://github.com/python/cpython/runs/3979900415?check_suite_focus=true


test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok

==
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
--
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, 
in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):

AssertionError: ConnectionError not raised

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-10-06 Thread Dennis Sweeney 


Change by Dennis Sweeney :


--
pull_requests:  -27076

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-10-04 Thread Dennis Sweeney 


Change by Dennis Sweeney :


--
nosy: +Dennis Sweeney
nosy_count: 8.0 -> 9.0
pull_requests: +27076
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28727

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-09-21 Thread Nikita Sobolev 


Nikita Sobolev  added the comment:

Happened to me today: 
https://dev.azure.com/Python/cpython/_build/results?buildId=88208=logs=c83831cd-3752-5cc7-2f01-8276919eb334=5a421c4a-0933-53d5-26b9-04b36ad165eb


```
test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests) ... FAIL
test test_asyncio failed
test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok

==
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
--
Traceback (most recent call last):
  File "D:\a\1\s\lib\test\test_asyncio\test_sendfile.py", line 457, in 
test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):

AssertionError: ConnectionError not raised

--
Ran 2 tests in 0.087s

FAILED (failures=1)
0:08:56 load avg: 3.51 Re-running test_concurrent_futures in verbose mode 
(matching: test_cancel_futures_wait_false)
test_cancel_futures_wait_false 
(test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok

--
Ran 1 test in 0.303s

OK
1 test failed again:
test_asyncio
```

--
nosy: +sobolevn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-08-17 Thread STINNER Victor 


STINNER Victor  added the comment:

Recent failure on GHA Windows x64:

https://github.com/python/cpython/runs/3342514542

2021-08-16T17:19:58.4338049Z 
==
2021-08-16T17:19:58.4339129Z FAIL: 
test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-08-16T17:19:58.4340315Z 
--
2021-08-16T17:19:58.4340937Z Traceback (most recent call last):
2021-08-16T17:19:58.4341846Z   File 
"D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in 
test_sendfile_close_peer_in_the_middle_of_receiving
2021-08-16T17:19:58.4342849Z with self.assertRaises(ConnectionError):
2021-08-16T17:19:58.4343398Z 
2021-08-16T17:19:58.4343982Z AssertionError: ConnectionError not raised

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-06-24 Thread Erlend E. Aasland 


Erlend E. Aasland  added the comment:

Two new failures today:

https://github.com/python/cpython/runs/2905621215:
2021-06-24T14:18:23.3772681Z 
==
2021-06-24T14:18:23.3773622Z FAIL: 
test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-06-24T14:18:23.3774665Z 
--
2021-06-24T14:18:23.3775258Z Traceback (most recent call last):
2021-06-24T14:18:23.3776123Z   File 
"D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in 
test_sendfile_close_peer_in_the_middle_of_receiving
2021-06-24T14:18:23.3777065Z with self.assertRaises(ConnectionError):
2021-06-24T14:18:23.375Z AssertionError: ConnectionError not raised
2021-06-24T14:18:23.3778226Z 
2021-06-24T14:18:23.3778744Z 
--
2021-06-24T14:18:23.3779161Z 
2021-06-24T14:18:23.3779555Z Ran 2022 tests in 54.341s
2021-06-24T14:18:23.3779870Z 
2021-06-24T14:18:23.3780352Z FAILED (failures=1, skipped=63)
2021-06-24T14:18:23.3780890Z test test_asyncio failed


https://github.com/python/cpython/runs/2906141524:
2021-06-24T15:23:11.7177493Z 
==
2021-06-24T15:23:11.7178338Z FAIL: 
test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-06-24T15:23:11.7179234Z 
--
2021-06-24T15:23:11.7179754Z Traceback (most recent call last):
2021-06-24T15:23:11.7180469Z   File 
"D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in 
test_sendfile_close_peer_in_the_middle_of_receiving
2021-06-24T15:23:11.7181284Z with self.assertRaises(ConnectionError):
2021-06-24T15:23:11.7182125Z AssertionError: ConnectionError not raised
2021-06-24T15:23:11.7182560Z 
2021-06-24T15:23:11.7183334Z 
--
2021-06-24T15:23:11.7183839Z

--
nosy: +erlendaasland

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-06-21 Thread STINNER Victor 


STINNER Victor  added the comment:

This bug still occurs time to time on GitHub Actions.

https://github.com/python/cpython/pull/26826/checks?check_run_id=2874631119

==
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving 
(test.test_asyncio.test_sendfile.ProactorEventLoopTests)
--
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, 
in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):
AssertionError: ConnectionError not raised

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-04-27 Thread Nick Coghlan 


Nick Coghlan  added the comment:

Another instance at 
https://github.com/python/cpython/pull/25585/checks?check_run_id=2447701034

I unlinked the previously linked PR, as that looked to be for bpo-43539 rather 
than this issue.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-04-27 Thread Nick Coghlan 


Change by Nick Coghlan :


--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-04-27 Thread Nick Coghlan 


Change by Nick Coghlan :


--
pull_requests:  -24157

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-04-15 Thread STINNER Victor 


Change by STINNER Victor :


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-04-15 Thread STINNER Victor 


Change by STINNER Victor :


--
title: test_asyncio: Proactor 
test_sendfile_close_peer_in_the_middle_of_receiving failure -> [Windows] 
test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving 
failure

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com