[issue41815] SQLite: segfault if backup called on closed database

2020-10-05 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset bd55c46895d2fcfadda46701d3c34d78441a7806 by Łukasz Langa (Miss 
Islington (bot)) in branch '3.9':
bpo-41815: SQLite: segfault if backup called on closed database (GH-22322)
https://github.com/python/cpython/commit/bd55c46895d2fcfadda46701d3c34d78441a7806


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-21 Thread Kyle Stanley 


Kyle Stanley  added the comment:

I've received approval from Lukasz to backport to 3.9 and 3.8, and have now 
merged the PRs.

It could use a post-commit review from a core dev that has some additional 
experience with SQLite3, but it can be de-escalated from release blocker.

--
priority: release blocker -> normal
stage: patch review -> commit review
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-21 Thread miss-islington 


miss-islington  added the comment:


New changeset 4ee30c42441c3e5066d5080a22da53675aeae716 by Miss Islington (bot) 
in branch '3.9':
bpo-41815: SQLite: segfault if backup called on closed database (GH-22322)
https://github.com/python/cpython/commit/4ee30c42441c3e5066d5080a22da53675aeae716


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-21 Thread miss-islington 


miss-islington  added the comment:


New changeset ca2d99d091a5b7768e92ee5ce7104aa6d8a3ed86 by Miss Islington (bot) 
in branch '3.8':
bpo-41815: SQLite: segfault if backup called on closed database (GH-22322)
https://github.com/python/cpython/commit/ca2d99d091a5b7768e92ee5ce7104aa6d8a3ed86


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-21 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +21385
pull_request: https://github.com/python/cpython/pull/22344

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-21 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +21386
pull_request: https://github.com/python/cpython/pull/22345

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread miss-islington 


miss-islington  added the comment:


New changeset bfee9fad84531a471fd7864e88947320669f68e2 by Peter McCormick in 
branch 'master':
bpo-41815: SQLite: segfault if backup called on closed database (GH-22322)
https://github.com/python/cpython/commit/bfee9fad84531a471fd7864e88947320669f68e2


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread Peter McCormick 


Peter McCormick  added the comment:

Updated sample script, thanks to @aeros for catching the omission:

```
import sqlite3
target = sqlite3.connect(':memory:')
source = sqlite3.connect(':memory:')
source.close()
source.backup(target)
```

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread Kyle Stanley 


Change by Kyle Stanley :


--
nosy: +ghaering

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread Kyle Stanley 


Kyle Stanley  added the comment:

With this being a segfault that's simple to replicate under normal 
circumstances, I've elevated the priority to release blocker. I'll wait on the 
release manager (Lukasz) for explicit approval for backporting to 3.9 and 3.8, 
with both branches being in the release candidate phase.

(The attached PR looks to be ready to be merged as well, after a Misc/NEWS 
entry is added by the author. See 
https://github.com/python/cpython/pull/22322#pullrequestreview-492167467 for 
details.)

--
nosy: +aeros, lukasz.langa
priority: normal -> release blocker
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread Roundup Robot 


Change by Roundup Robot :


--
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +21367
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41815] SQLite: segfault if backup called on closed database

2020-09-19 Thread Peter McCormick 


New submission from Peter McCormick :

Attempting to backup a closed database will trigger segfault:

```
target = sqlite.connect(':memory:')
source = sqlite.connect(":memory:")
source.close()
source.backup(target)
```

--
files: fix.patch
keywords: patch
messages: 377176
nosy: pdmccormick
priority: normal
severity: normal
status: open
title: SQLite: segfault if backup called on closed database
type: crash
versions: Python 3.10, Python 3.7, Python 3.8, Python 3.9
Added file: https://bugs.python.org/file49464/fix.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com