[issue4211] frozen packages set an improper __path__ value
Nick Coghlan [EMAIL PROTECTED] added the comment: FWIW, I agree with the idea of fixing it for 3.0 and leaving it in for 2.x. -- nosy: +ncoghlan ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4211] frozen packages set an improper __path__ value
Benjamin Peterson [EMAIL PROTECTED] added the comment: Fixed in r67112. -- nosy: +benjamin.peterson resolution: accepted - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4211] frozen packages set an improper __path__ value
Changes by Brett Cannon [EMAIL PROTECTED]: -- stage: - commit review ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4211] frozen packages set an improper __path__ value
Brett Cannon [EMAIL PROTECTED] added the comment: I have an attached patch that fixes the reported problem. First, it adds a sanity check that no empty module name is checked for (crashes the interpreter otherwise). Second, the __path__ attribute is now a list. This does break backwards-compatibility and thus cannot be backported to 2.6. Third, I removed the special-casing of frozen packages and just made frozen module checks a universal thing. This did change the module resolution order such that frozen modules are checked before built-in modules and registered modules under Windows (whatever those are). Moving frozen modules after those two cases are possible if it's really desired. At this point I need a review to get this into 3.0 and a decision on whether to backport to 2.7 (I say don't bother, out of backward-compatibility, but it probably wouldn't really hurt anything either). -- assignee: brett.cannon - keywords: +needs review, patch Added file: http://bugs.python.org/file11920/issue4211.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4211] frozen packages set an improper __path__ value
Brett Cannon [EMAIL PROTECTED] added the comment: Looking at Python/import.c:find_module, fixing this will require changing the setting of __path__ for frozen packages and how frozen modules are found. The former will require changing PyImport_ImportFrozenModule() to use a list instead of a string for the packages. To make the change work for find frozen modules, find_module() will need to change. Basically the special-casing for 'path' around frozen module just needs to go. This will lead to a slight performance penalty as all imports will require checking for an equivalent frozen module, but since it is a strcmp in a loop it should not be too bad. The performance cost can go away if some strapping young lad happens to re-implement import in such a way that the frozen module parts can easily be left out. =) Setting as a release blocker for now in case Barry is willing to let this go into 3.0rc4. -- assignee: - brett.cannon priority: - release blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4211] frozen packages set an improper __path__ value
New submission from Brett Cannon [EMAIL PROTECTED]: If you import a frozen package (e.g. __phello__), __path__ is set to '__phello__'. But this should be a list as specified by both PEP 302 (http://www.python.org/dev/peps/pep-0302/) and the original doc outlining the package mechanism (http://www.python.org/doc/essays/packages.html). Changing import to put the string in a list is all that is needed to correct this (although it might break some code relying on the fact that it has been a string in previous versions). -- components: Interpreter Core messages: 75250 nosy: brett.cannon severity: normal status: open title: frozen packages set an improper __path__ value type: behavior versions: Python 2.5, Python 2.6, Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4211 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
