[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> unittest swallows part of stack trace when raising 
AssertionError in a TestCase

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Irit Katriel  added the comment:

I think this is the same as issue37712.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Irit Katriel  added the comment:

I made a patch that replaces the limit hack by a filter on the traceback. We 
could stop here an just fix this, or we could create a more generic filter in 
the traceback module as suggested in issue31299.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22556
pull_request: https://github.com/python/cpython/pull/23688

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22555
pull_request: https://github.com/python/cpython/pull/23687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests:  -22552

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22552
pull_request: https://github.com/python/cpython/pull/23687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests:  -22552

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.10 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +patch
nosy: +iritkatriel
nosy_count: 1.0 -> 2.0
pull_requests: +22552
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42247] unittest hides traceback frames in chained exceptions

[David Mandelberg]

New submission from David Mandelberg :

The traceback in the output of the attached test (see below) doesn't include 
line 5, which is where the original exception is raised. I think this is 
because 
https://github.com/python/cpython/blob/b9ee4af4c643a323779fd7076e80b29d611f2709/Lib/unittest/result.py#L180-L186
 uses the `limit` parameter to try to hide the implementation of `self.fail()` 
from the traceback, but `traceback.TracebackException.format()` applies the 
limit to the chained exception. I'm not sure if that's a bug in unittest or 
traceback, but from the comment in the above part of unittest, I don't think 
it's intentional.


F
==
FAIL: test_foo (__main__.FooTest)
--
Traceback (most recent call last):
  File "foo.py", line 12, in test_foo
foo()
ValueError: foo

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "foo.py", line 14, in test_foo
self.fail('foo() raised ValueError')
AssertionError: foo() raised ValueError

--
Ran 1 test in 0.000s

FAILED (failures=1)

--
components: Library (Lib)
files: foo.py
messages: 380244
nosy: dseomn
priority: normal
severity: normal
status: open
title: unittest hides traceback frames in chained exceptions
type: behavior
versions: Python 3.8
Added file: https://bugs.python.org/file49563/foo.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com