[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Steve Dower  added the comment:


New changeset db91714faa6d3ede59003cdcc719a758160f3970 by Steve Dower in branch 
'3.8':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
https://github.com/python/cpython/commit/db91714faa6d3ede59003cdcc719a758160f3970


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Change by Steve Dower :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +22963
pull_request: https://github.com/python/cpython/pull/24133

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

> Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done 
> at the same time and they both keep causing merge conflicts.

No problem. I noticed that, so I aborted my cherry-picker.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Steve Dower  added the comment:


New changeset 77d54710506b67e48b50bb1758fb31fc33a33c83 by Steve Dower in branch 
'3.9':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
https://github.com/python/cpython/commit/77d54710506b67e48b50bb1758fb31fc33a33c83


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Steve Dower  added the comment:

> Steve Dower, do you mind if I create backports for the Windows build as well?

Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done 
at the same time and they both keep causing merge conflicts.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +22962
pull_request: https://github.com/python/cpython/pull/24132

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[miss-islington]

miss-islington  added the comment:


New changeset e9a71dab094c0467f07d13cce4324c8a93727863 by Erlend Egeberg 
Aasland in branch '3.9':
[3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) 
(GH-24130)
https://github.com/python/cpython/commit/e9a71dab094c0467f07d13cce4324c8a93727863


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[miss-islington]

miss-islington  added the comment:


New changeset f27451dc35f1c69be0c26e8aeafee7ba6771039a by Erlend Egeberg 
Aasland in branch '3.8':
[3.8] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674). 
(GH-24129)
https://github.com/python/cpython/commit/f27451dc35f1c69be0c26e8aeafee7ba6771039a


--
nosy: +miss-islington
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Steve Dower, do you mind if I create backports for the Windows build as well?

--
resolution:  -> fixed
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +22960
pull_request: https://github.com/python/cpython/pull/24130

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +22959
pull_request: https://github.com/python/cpython/pull/24129

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Ned Deily, can you fix the macOS backports?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Steve Dower  added the comment:


New changeset dd74c01d3bd2833f72ffe400a1d10b8583c0ba6a by Erlend Egeberg 
Aasland in branch 'master':
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
https://github.com/python/cpython/commit/dd74c01d3bd2833f72ffe400a1d10b8583c0ba6a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

> FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied 
> there are no issues).

A CI check would indicate that there are no issues. The PoC CI is just a short 
bash script wrapped in GitHub's workflow syntax. I'd be happy to maintain it, 
FWIW. On the other hand, adding a CI check is not super important for me :)

https://sqlite.org/versionnumbers.html:
"[…] the current tarball naming conventions only reserve two digits for the Y 
and so the naming format for downloads will need to be revised in about 2030."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Steve Dower]

Steve Dower  added the comment:

Honestly, keeping a CI run alive is more work than just doing the extract and 
push myself. I know this means it feels like you can't do as much yourself to 
speed up the integration, but it really isn't going to slow it down that much.

FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied 
there are no issues). It's only OpenSSL that relies on running a signed build.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


Added file: 
https://bugs.python.org/file49718/0001-Add-simple-validation-CI.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


Removed file: 
https://bugs.python.org/file49694/0001-Add-simple-validation-CI.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Ned Deily]

Ned Deily  added the comment:


New changeset c94ee13ad596d26d1859078bc09806aa59bb by Erlend Egeberg 
Aasland in branch 'master':
bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674)
https://github.com/python/cpython/commit/c94ee13ad596d26d1859078bc09806aa59bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

See attached proof-of-concept CI check. This GitHub Workflow extracts the 
SQLite version information, downloads the amalgamation source code, and does a 
simple `cmp` on each file.

Example run: 
https://github.com/erlend-aasland/cpython-source-deps/runs/1586069119?check_suite_focus=true

--
Added file: 
https://bugs.python.org/file49694/0001-Add-simple-validation-CI.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Steve Dower: It should be fairly easy to add a CI check that validates the 
source checksums, so you don't need to do it manually every time. I can throw 
up a simple GH workflow for the sqlite branch if you want.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
nosy: +ned.deily, steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +22541
pull_request: https://github.com/python/cpython/pull/23675

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +22540
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23674

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42584] Upgrade macOS and Windows installers to use SQLite 3.34.0

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

SQLite 3.34.0 was released 2020-12-01: 
https://www.sqlite.org/releaselog/3_34_0.html

Compiles fine on master, and tests are completing without error.

--
components: Library (Lib)
messages: 382625
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Upgrade macOS and Windows installers to use SQLite 3.34.0
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com