[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[Ned Deily]

Ned Deily  added the comment:

Thanks for the PR!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[Ned Deily]

Ned Deily  added the comment:


New changeset eedeaef1f22d27264ce9b031da80fe2485e85e69 by Miss Islington (bot) 
in branch '3.9':
bpo-42692: fix __builtin_available check on older compilers (GH-23873) 
(GH-24090)
https://github.com/python/cpython/commit/eedeaef1f22d27264ce9b031da80fe2485e85e69


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[miss-islington]

Change by miss-islington :


--
pull_requests: +22921
pull_request: https://github.com/python/cpython/pull/24090

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[miss-islington]

miss-islington  added the comment:


New changeset df21f502fdccec234282bf0a211af979fd23def4 by Joshua Root in branch 
'master':
bpo-42692: fix __builtin_available check on older compilers (GH-23873)
https://github.com/python/cpython/commit/df21f502fdccec234282bf0a211af979fd23def4


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[Joshua Root]

Change by Joshua Root :


--
keywords: +patch
pull_requests: +22735
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23873

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42692] Build fails on macOS when compiler doesn't define __has_builtin

[Joshua Root]

New submission from Joshua Root :

The line in posixmodule.c that checks for __builtin_available is rejected by 
compilers that don't have __has_builtin. The second check needs to be in a 
nested #if.

--
components: Build, macOS
messages: 383437
nosy: jmr, ned.deily, ronaldoussoren
priority: normal
severity: normal
status: open
title: Build fails on macOS when compiler doesn't define __has_builtin
type: compile error
versions: Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com