[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[STINNER Victor]

STINNER Victor  added the comment:

The two FreeBSD 3.x buildbot are back to green, I close the issue.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[Kubilay Kocak]

Kubilay Kocak  added the comment:

P.S gdb and bash have been rebuilt :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[Kubilay Kocak]

Kubilay Kocak  added the comment:

Note: Not suggesting dep removals, just a try-except-skip block in the 
(hopefully) one place the sub-process handler in the test framework that runs 
then :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[STINNER Victor]

STINNER Victor  added the comment:

> As far as I'm aware, the best practice and recommendation for these cases is 
> that 'tests should not test dependencies', and to skip/skipif these 
> (external) dependencies are not available or fail to load/run.

In theory, we should limit external dependencies. In practice, it's too 
convenient to make the assumption that some Unix programs are available and 
work properly.

But PRs are welcome to reduce dependencies to external tools ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[Kubilay Kocak]

Kubilay Kocak  added the comment:

Rebuilding bash & gdb now to pickup new/updated ncurses library.

Still suggest picking up "subprocess.CalledProcessError" generically in test 
framework for tests that use subprocess/external commands

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[Kubilay Kocak]

Kubilay Kocak  added the comment:

The failure mode is a generic "an external dependency expected by a test suite 
is not available or doesn't run", applying to many core Python test that 
invokes an external utilities, and not specific to OS.

As far as I'm aware, the best practice and recommendation for these cases is 
that 'tests should not test dependencies', and to skip/skipif these (external) 
dependencies are not available or fail to load/run.

Of course, the call is yours :)

I'll rebuild gdb/bash if you decide you don't want the error to remain to test 
improving the test suite.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[STINNER Victor]

STINNER Victor  added the comment:

> Would you like me to rebuild bash/gdb to fix the error, or wait for the tests 
> to be fixed so that they can handle the error condition?

I don't think that Python test suite should handle the case of a broken FreeBSD 
setup.

Could you either disable the buildbot worker or fix it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[Kubilay Kocak]

Kubilay Kocak  added the comment:

FreeBSD base was updated on the FreeBSD workers, between versions that changes 
the way the base curses library was built, and what it built.

The net results was that any software (from ports) linked against base curses 
needed to be rebuilt, and until then would fail to load with the following 
error:

  ld-elf.so.1: Shared object "libncursesw.so.6" not found, required by "foo"


The test suite should guard/test for the inability to execute (successfully 
load/run) the required commands/functions.

The following tests also failed for the same reason:

==
ERROR: test_deactivate_with_strict_bash_opts (test.test_venv.BasicTest)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", 
line 391, in test_deactivate_with_strict_bash_opts
out, err = check_output([bash, test_script])
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", 
line 44, in check_output
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['/usr/local/bin/bash', 
'/var/tmp/tmprk2_yuoe/test_strict.sh']' returned non-zero exit status 1.

0:14:07 load avg: 1.31 Re-running test_gdb in verbose mode
test test_gdb crashed -- Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py",
 line 270, in _runtest_inner
refleak = _runtest_inner2(ns, test_name)
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py",
 line 221, in _runtest_inner2
the_module = importlib.import_module(abstest)
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/importlib/__init__.py",
 line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
  File "", line 1030, in _gcd_import
  File "", line 1007, in _find_and_load
  File "", line 986, in _find_and_load_unlocked
  File "", line 680, in _load_unlocked
  File "", line 790, in exec_module
  File "", line 228, in _call_with_frames_removed
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_gdb.py", 
line 48, in 
gdb_version, gdb_major_version, gdb_minor_version = get_gdb_version()
  File 
"/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_gdb.py", 
line 29, in get_gdb_version
raise Exception(f"Command {' '.join(cmd)!r} failed "
Exception: Command 'gdb -nx --version' failed with exit code 1: stdout='' 
stderr='ld-elf.so.1: Shared object "libncursesw.so.6" not found, required by 
"gdb"\n'

Would you like me to rebuild bash/gdb to fix the error, or wait for the tests 
to be fixed so that they can handle the error condition?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +koobs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43068] test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x

[STINNER Victor]

New submission from STINNER Victor :

https://buildbot.python.org/all/#/builders/483/builds/758

FAIL: test_specific_shell (test.test_subprocess.POSIXProcessTestCase)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_subprocess.py",
 line 2286, in test_specific_shell
self.assertEqual(p.stdout.read().strip(), bytes(sh, 'ascii'))
AssertionError: b'' != b'/usr/local/bin/bash'

AMD64 FreeBSD Shared 3.9 is also affected:
https://buildbot.python.org/all/#/builders/151/builds/283

And AMD64 FreeBSD Shared 3.8:
https://buildbot.python.org/all/#/builders/555/builds/197

--
components: Tests
messages: 385945
nosy: vstinner
priority: normal
severity: normal
status: open
title: test_subprocess: test_specific_shell() fails on AMD64 FreeBSD Shared 3.x
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com