[issue4350] Remove dead code from Tkinter.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7e6beea0eeab by Serhiy Storchaka in branch 'default':
Issue #22061: Restored empty obsolete methods removed in issue #4350 and
http://hg.python.org/cpython/rev/7e6beea0eeab

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 549a7615abe3 by Serhiy Storchaka in branch 'default':
Issue #4350: Removed a number of out-of-dated and non-working for a long time
http://hg.python.org/cpython/rev/549a7615abe3

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Patch is synchronized with tip. It also removes Studbutton and Tributton 
classes which depend on removed methods. These classes are not documented, not 
tested and never worked in supported Python versions. I even not found 
reasonable links in Google, except an annotation [1] and autogenerated from 
Tkinter sources docs.

I now think that perhaps we should apply this patch to 2.7 and 3.4 too. 
Non-working (and non-worked last 10 or 15 or more years) code only confuses 
people.

[1] http://legacy.python.org/search/hypermail/python-1994q2/1023.html

--
Added file: http://bugs.python.org/file35444/tkinter_remove_dead_code-3.5.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
components: +Tkinter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage: patch review -> commit review
type: behavior -> enhancement
versions:  -Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Georg Brandl]

Georg Brandl added the comment:

This kind of change is very similar to other "cleanup" changes, so the 
classification of "not a bug fix" seems valid.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM. However I am not sure should this issue be classified as "behavior" or 
"enhancement". Removed code is not usable in Tk versions which supported in 
Python 2.7 and 3.2+ and can be removed safely.

--
nosy: +georg.brandl, serhiy.storchaka
versions: +Python 3.3, Python 3.4 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Guilherme Polo]

Guilherme Polo  added the comment:

If we consider the meaning of "dead code" as that used in compilers, then I 
meant "out of date" code.

If you want to add support for tk::ButtonEnter then I believe you should open a 
new issue and raise your points there. Anyway, have you read 
http://www.mail-archive.com/python-list@python.org/msg210494.html ? Does it 
relate to your use case ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Graham Horler]

Graham Horler  added the comment:

Are we sure this is dead code, and not just out of date?

e.g. this works, and I use it in production with "if Tkinter.TkVersion >= 8.4":

b = Tkinter.Button(root)
b.tk.call('tk::ButtonEnter', b._w)

--
nosy: +pysquared

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Mark Lawrence]

Mark Lawrence  added the comment:

Ther title says it all, can we commit this?

--
nosy: +BreamoreBoy
stage:  -> patch review
type:  -> behavior
versions: +Python 3.1, Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4350] Remove dead code from Tkinter.py

[Guilherme Polo]

New submission from Guilherme Polo <[EMAIL PROTECTED]>:

There are some methods (which call tk commands) that no longer exist,
for a long time now so this patch remove them.

There are also these "indices" functions, which do not belong to the
module space and now are gone too.

--
files: remove_dead_code.diff
keywords: patch
messages: 76030
nosy: gpolo
severity: normal
status: open
title: Remove dead code from Tkinter.py
versions: Python 2.7, Python 3.0
Added file: http://bugs.python.org/file12050/remove_dead_code.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com