[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

> Making SQLITE_OMIT_AUTOINIT the default behavior would pretty much break 
> every application that use SQLite [...]

Yeah, I know, _but_ if some user decides use a SQLite library compiled with 
SQLITE_OMIT_AUTOINIT (because it is mentioned in the "Recommended Compile-time 
Optinos"[1]), Python 3.10 won't break :)


[1] https://sqlite.org/compile.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Berker Peksag]

Berker Peksag  added the comment:


New changeset def919342facf7f53a3a5f0e9f4b1889d323956d by Erlend Egeberg 
Aasland in branch 'master':
bpo-43505: Explicitly initialize and shutdown sqlite3 (GH-25404)
https://github.com/python/cpython/commit/def919342facf7f53a3a5f0e9f4b1889d323956d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Berker Peksag]

Berker Peksag  added the comment:

Making SQLITE_OMIT_AUTOINIT the default behavior would pretty much break every 
application that use SQLite, but since the PR is small enough and uses the 
interface in the correct way, I don't see a strong reason to reject it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +24137
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25404

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43505] [sqlite3] Explicitly initialise and shut down sqlite3

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

We should explicitly initialise (and shut down) the SQLite library in the 
sqlite3 module. This may be required in future releases:

Quoting from the SQLite docs:
"For maximum portability, it is recommended that applications always invoke 
sqlite3_initialize() directly prior to using any other SQLite interface. Future 
releases of SQLite may require this. In other words, the behavior exhibited 
when SQLite is compiled with SQLITE_OMIT_AUTOINIT might become the default 
behavior in some future release of SQLite."

Ref.
- https://sqlite.org/c3ref/initialize.html
- https://sqlite.org/compile.html#omit_autoinit

--
components: Library (Lib)
messages: 388788
nosy: berker.peksag, erlendaasland, serhiy.storchaka
priority: normal
severity: normal
status: open
title: [sqlite3] Explicitly initialise and shut down sqlite3
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com