[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Jelle Zijlstra]

Change by Jelle Zijlstra :


--
nosy: +Jelle Zijlstra
nosy_count: 4.0 -> 5.0
pull_requests: +29083
pull_request: https://github.com/python/cpython/pull/30904

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Dong-hee Na  added the comment:

@vstinner

I noticed that the msg390083 was based on a non-optimized build.
https://github.com/python/cpython/pull/25154#issuecomment-949061515 ran with 
the same build option condition.

Here is the PGO + LTO based benchmark.
Still fast.

+-+--+--+
| Benchmark   | base_opt | vectorcall_opt   |
+=+==+==+
| bench enumerate | 384 ns   | 277 ns: 1.39x faster |
+-+--+--+

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Change by Dong-hee Na :


--
versions: +Python 3.11 -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Dong-hee Na  added the comment:

Thanks Victor!

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset 83f202a802b0810e2f0900c6d298fd104390f2ba by Dong-hee Na in branch 
'main':
bpo-43706: Use PEP 590 vectorcall to speed up enumerate() (GH-25154)
https://github.com/python/cpython/commit/83f202a802b0810e2f0900c6d298fd104390f2ba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +kj

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Dong-hee Na  added the comment:

See my last benchmark

https://github.com/python/cpython/pull/25154#issuecomment-949061515

Same result in both Linux VM and Macbook pro.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +23901
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25154

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

Change by Dong-hee Na :


--
type:  -> performance
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43706] enumerate() instantiation time reducing by using PEP 590 vectorcall

[Dong-hee Na]

New submission from Dong-hee Na :

Finally, I success to implement PEP 590 for enumerate type which is the 
well-used type in Python.

Amazingly enhanced!

+-+++
| Benchmark   | enumerate_bench_master | enumerate_bench_vectorcall |
+=+++
| bench enumerate | 527 ns | 380 ns: 1.39x faster   |
+-+++

--
files: bench_enumerate.py
messages: 390083
nosy: corona10, vstinner, xtreak
priority: normal
severity: normal
status: open
title: enumerate() instantiation time reducing by using PEP 590 vectorcall
Added file: https://bugs.python.org/file49929/bench_enumerate.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com