[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

[David Bolen]

David Bolen  added the comment:

No longer needed after commit c368ce74d2c9bcbf1ec320466819c2d4768252f7

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

[David Bolen]

David Bolen  added the comment:

Based on further information in issue #27129 as well as issue #43719 it appears 
a source of the problem prompting this fix was a failure to update the magic 
number in the original commit for #27129.

The windows clean script does still leave more artifacts than, for example, the 
Unix Makefile, but it shouldn't have resulted in a problem if the magic number 
had changed, and it's not clear it has to change after all.  So this issue can 
probably be closed once that is corrected.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

[David Bolen]

Change by David Bolen :


--
keywords: +patch
pull_requests: +23904
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25157

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

[David Bolen]

David Bolen  added the comment:

Something like this is a quick 'n dirty minimal fix - at least it seems to 
solve the problem that arose in issue #27129 on the Win10 buildbot:

--- a/Tools/buildbot/clean.bat
+++ b/Tools/buildbot/clean.bat
@@ -11,6 +11,8 @@ call "%pcbuild%\build.bat" -t Clean -k -d %*
 
 echo Deleting .pyc/.pyo files ...
 del /s "%root%\Lib\*.pyc" "%root%\Lib\*.pyo"
+del /s "%root%\Tools\*.pyc" "%root%\Tools\*.pyo"
+del /s "%root%\Parser\*.pyc" "%root%\Parser\*.pyo"
 
 echo Deleting test leftovers ...
 rmdir /s /q "%root%\build"

but since this only covers the buildbot script, someone working within the 
regular VS IDE and just using the clean target of the projects could presumably 
run into the same issue.  Or is there some other way to fully clean a working 
tree from within the IDE?  Not sure how important that is to address in any 
event.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43709] Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal

[David Bolen]

New submission from David Bolen :

The Tools\buildbot\clean.bat script used on Windows only removes pyc/pyo files 
from the Lib tree, leaving some files beneath Tools (clinic and peg_generator) 
and Parser (asdl).  This can cause failures following commits that affect those 
files, such as fcb55c0037baab6f98f91ee38ce84b6f874f034a (in issue #27129) 
leading to subsequent crashes or anomalous behavior.

This appears to have been true for a while, though only the 3.10 branch ran 
into the issue, so any fix might also be back-ported to the other active 
branches.

--
components: Build, Windows
messages: 390098
nosy: db3l, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Windows Tools\buildbot\clean.bat misses some needed pyc/pyo removal
type: crash
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com