[issue43718] HTTP CONNECT response not subject to debug level

[Andrei Kulakov]

Andrei Kulakov  added the comment:

The PR is here:
https://github.com/python/cpython/pull/26932

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43718] HTTP CONNECT response not subject to debug level

[Andrei Kulakov]

Change by Andrei Kulakov :


--
keywords: +patch
pull_requests: +25501
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26932

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43718] HTTP CONNECT response not subject to debug level

[Michael Osipov]

Michael Osipov <1983-01...@gmx.net> added the comment:

Thanks Andrei, please ahead and provide the PR. You'll do it faster than I do.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43718] HTTP CONNECT response not subject to debug level

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Also note that the debug arg should be provided only if it's greater than 0, 
for cases when you might want to have connection at debug 0, and a custom 
response class with a default nonzero debug level.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43718] HTTP CONNECT response not subject to debug level

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Michael: Thanks for the report! would you like to create a PR? If not, I can do 
that.

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43718] HTTP CONNECT response not subject to debug level

[Michael Osipov]

New submission from Michael Osipov <1983-01...@gmx.net>:

Looking at 
https://github.com/python/cpython/blob/63c69440c7adb0de1d191a8d3d100b335d5c2f81/Lib/http/client.py#L898
self.debuglevel is not passed to response_class() and for debugging purposes I 
miss to see:
> send: b'CONNECT some-host:443 HTTP/1.0\r\n'
> send: b'\r\n'
> reply: 'HTTP/1.0 502 Bad Gateway\r\n'

reply is missing. It trivial to pass the debug level.

--
components: Library (Lib)
messages: 390139
nosy: michael-o
priority: normal
severity: normal
status: open
title: HTTP CONNECT response not subject to debug level
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com