[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Vincent Michel]

Change by Vincent Michel :


--
pull_requests:  -26670

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Vincent Michel]

Change by Vincent Michel :


--
nosy: +vxgmichel
nosy_count: 2.0 -> 3.0
pull_requests: +26670
pull_request: https://github.com/python/cpython/pull/28250

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your contribution Daniel.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 556d5ad11fb380868c19beeba53d49f89c27f32d by Daniel Hillier in 
branch 'main':
bpo-44129: Add descriptive global variables for general purpose bit flags 
(GH-26118)
https://github.com/python/cpython/commit/556d5ad11fb380868c19beeba53d49f89c27f32d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Daniel Hillier]

Change by Daniel Hillier :


--
keywords: +patch
pull_requests: +24763
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26118

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44129] zipfile: Add descriptive global variables for general purpose bit flags

[Daniel Hillier]

New submission from Daniel Hillier :

In the zipfile module, masking of bit flags is done against hex numbers eg. if 
flags & 0x800...

To increase readability I suggest we replace these with global variables named 
for the purpose of the flag. From the example above:

if flags & 0x800
becomes:
if flags & _MASK_UTF_FILENAME

--
components: Library (Lib)
messages: 393622
nosy: dhillier, serhiy.storchaka
priority: normal
severity: normal
status: open
title: zipfile: Add descriptive global variables for general purpose bit flags
versions: Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com