[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Eric V. Smith


Eric V. Smith  added the comment:

Yes, thank you Leonardo!

There are probably places in the stdlib where changing to f-strings would be a 
performance improvement. Of course finding those places is the challenge!

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Leonardo Freua


Leonardo Freua  added the comment:

Thanks, Ammar. I'll look.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Ammar Askar


Ammar Askar  added the comment:

Thanks for trying to help Leonardo! You might consider looking for easy issues 
on the bug tracker or reviewing open pull requests to help. Definitely take a 
look at the dev guide :) https://cpython-devguide.readthedocs.io/fixingissues/

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Leonardo Freua


Leonardo Freua  added the comment:

Understood. Anyway, it was good to try to help at this point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Ammar Askar


Ammar Askar  added the comment:

As per https://bugs.python.org/issue36249 and https://bugs.python.org/issue38351

We don't generally do large-scale changes that are mostly formatting based. We 
would prefer that these sort of improvements happen when someone happens to be 
touching that code anyway unless there is a demonstrable improvement from them.

--
nosy: +ammar2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Leonardo Freua


Change by Leonardo Freua :


--
keywords: +patch
pull_requests: +25648
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27100

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44612] inspect module points that could be using f-String

2021-07-12 Thread Leonardo Freua


New submission from Leonardo Freua :

There are some points in inspect module (I counted 48 since version 3.7) that 
could be using f-String formatting instead of format().

Changing these points will improve code readability, it will also decrease the 
complexity at these points and not to mention the fact that f-String formatting 
has better performance.

Obs.: Many other points could receive this improvement in other modules. This 
would provide the improvements I mentioned earlier, especially in older 
snippets of code.

--
components: Library (Lib)
messages: 397343
nosy: Leonardofreua
priority: normal
severity: normal
status: open
title: inspect module points that could be using f-String
type: enhancement
versions: Python 3.10, Python 3.11, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com