[issue44676] Add ability to serialise types.Union

[Ken Jin]

Ken Jin  added the comment:

This is fixed. Thanks Yurii and Serhiy for the patches :) (and everyone else 
for the reviews too).

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 0aea99e44416f37c75e5540072156dbf90ef1659 by Miss Islington (bot) 
in branch '3.10':
bpo-44676: Serialize the union type using only public API (GH-27323) (GH-27340)
https://github.com/python/cpython/commit/0aea99e44416f37c75e5540072156dbf90ef1659


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[miss-islington]

Change by miss-islington :


--
pull_requests: +25883
pull_request: https://github.com/python/cpython/pull/27340

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 435a0334d341e5f8faed594d9f015746bb7845db by Serhiy Storchaka in 
branch 'main':
bpo-44676: Serialize the union type using only public API (GH-27323)
https://github.com/python/cpython/commit/435a0334d341e5f8faed594d9f015746bb7845db


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +Interpreter Core, Library (Lib)
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Ken Jin]

Change by Ken Jin :


--
nosy: +kj
nosy_count: 5.0 -> 6.0
pull_requests: +25878
pull_request: https://github.com/python/cpython/pull/27335

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[miss-islington]

miss-islington  added the comment:


New changeset 8158e059e9952f08d19a18d3e9e021cee2393cd2 by Pablo Galindo Salgado 
in branch 'main':
bpo-44676: Fix reference leaks in union_reduce (GH-27332)
https://github.com/python/cpython/commit/8158e059e9952f08d19a18d3e9e021cee2393cd2


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 9356d1e47de583fd794e9d29abc448759f7a4109 by Pablo Galindo Salgado 
in branch '3.10':
[3.10] bpo-44676: Add ability to serialize types.Union (GH-27244) (GH-27333)
https://github.com/python/cpython/commit/9356d1e47de583fd794e9d29abc448759f7a4109


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +25876
pull_request: https://github.com/python/cpython/pull/27333

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +25875
pull_request: https://github.com/python/cpython/pull/27332

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This PR has introduced reference leaks. Bisecting points to:

fe13f0b0f696464dd6f283576668dbf57cb11399 is the first bad commit
commit fe13f0b0f696464dd6f283576668dbf57cb11399
Author: Yurii Karabas <1998uri...@gmail.com>
Date:   Fri Jul 23 12:47:00 2021 +0300

bpo-44676: Add ability to serialize types.Union (GH-27244)

 Lib/test/test_types.py | 35 +++
 Lib/typing.py  |  4 +-
 .../2021-07-19-19-53-46.bpo-44676.WgIMvh.rst   |  2 +
 Objects/unionobject.c  | 51 ++
 4 files changed, 90 insertions(+), 2 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core and 
Builtins/2021-07-19-19-53-46.bpo-44676.WgIMvh.rst
bisect run successfe13f0b0f696464dd6f283576668dbf57cb11399 is the first bad 
commit
commit fe13f0b0f696464dd6f283576668dbf57cb11399
Author: Yurii Karabas <1998uri...@gmail.com>
Date:   Fri Jul 23 12:47:00 2021 +0300

bpo-44676: Add ability to serialize types.Union (GH-27244)

 Lib/test/test_types.py | 35 +++
 Lib/typing.py  |  4 +-
 .../2021-07-19-19-53-46.bpo-44676.WgIMvh.rst   |  2 +
 Objects/unionobject.c  | 51 ++
 4 files changed, 90 insertions(+), 2 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core and 
Builtins/2021-07-19-19-53-46.bpo-44676.WgIMvh.rst
bisect run success

Example failure:

https://buildbot.python.org/all/#/builders/259/builds/100

Ran 106 tests in 0.053s
OK
..
test_types leaked [2, 2, 2] references, sum=6
test_types leaked [1, 1, 1] memory blocks, sum=3
1 test failed again:
test_types
== Tests result: FAILURE then FAILURE ==
413 tests OK.

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +25867
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/27323

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It is not good to use private method in pickle, because we will not be able to 
get rid of it for backward compatibility. Why not use functools.reduce()?

--
nosy: +serhiy.storchaka
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Łukasz Langa]

Change by Łukasz Langa :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset fe13f0b0f696464dd6f283576668dbf57cb11399 by Yurii Karabas in 
branch 'main':
bpo-44676: Add ability to serialize types.Union (GH-27244)
https://github.com/python/cpython/commit/fe13f0b0f696464dd6f283576668dbf57cb11399


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Yurii Karabas]

Change by Yurii Karabas <1998uri...@gmail.com>:


--
keywords: +patch
pull_requests: +25792
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/27244

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Yurii Karabas]

Change by Yurii Karabas <1998uri...@gmail.com>:


--
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Yurii Karabas]

Change by Yurii Karabas <1998uri...@gmail.com>:


--
versions: +Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44676] Add ability to serialise types.Union

[Yurii Karabas]

New submission from Yurii Karabas <1998uri...@gmail.com>:

It was discussed at https://bugs.python.org/issue44490

--
messages: 397814
nosy: uriyyo
priority: normal
severity: normal
status: open
title: Add ability to serialise types.Union

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com