[issue45041] [sqlite3] simplify executescript()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 3f2c433da560d7999a52f9fcba4bbd0898848520 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45041: Restore `sqlite3` executescript behaviour for `SELECT` queries 
(GH-28509)
https://github.com/python/cpython/commit/3f2c433da560d7999a52f9fcba4bbd0898848520


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +26906
pull_request: https://github.com/python/cpython/pull/28509

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Thanks for reviewing, Pablo!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset a6779715c4d0289acb59a8fd3660ab2e5d486c4b by Erlend Egeberg 
Aasland in branch 'main':
bpo-45041: Simplify `sqlite3.Cursor.executescript()` (GH-28020)
https://github.com/python/cpython/commit/a6779715c4d0289acb59a8fd3660ab2e5d486c4b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset e34bb409197d72711ae2c6197f9d8305533034d4 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45041: Increase coverage for sqlite3.Cursor.executescript() (GH-28074)
https://github.com/python/cpython/commit/e34bb409197d72711ae2c6197f9d8305533034d4


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +26518
pull_request: https://github.com/python/cpython/pull/28074

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Erlend E. Aasland]

New submission from Erlend E. Aasland :

See also bpo-45040

Since sqlite3_finalize() will pass on any error message set by sqlite3_step(), 
we can greatly simplify SQLite C API usage and error handling in 
sqlite3.Cursor.executescript(), thus reducing the number of times we 
save/restore thread state, and also simplifying error handling greatly.

We can also "inline" the commit before the main loop using the SQLite API 
directly, instead of calling self.commit()

Diffstat for the proposed patch:
1 file changed, 25 insertions(+), 42 deletions(-)

--
components: Extension Modules
messages: 400505
nosy: erlendaasland
priority: low
severity: normal
status: open
title: [sqlite3] simplify executescript()
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45041] [sqlite3] simplify executescript()

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +26466
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28020

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com