[issue45059] Typo: using "==" instead of "="

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

miss-islington  added the comment:


New changeset 2280bc116301d45efc4d69cea452d272fdcd05b1 by Miss Islington (bot) 
in branch '3.9':
bpo-45059: Add module cleanup to IDLE test_macosx (GH-28102)
https://github.com/python/cpython/commit/2280bc116301d45efc4d69cea452d272fdcd05b1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

miss-islington  added the comment:


New changeset 0f274cb2d78f71073e9d7295df3b9006e7bf1097 by Miss Islington (bot) 
in branch '3.10':
bpo-45059: Add module cleanup to IDLE test_macosx (GH-28102)
https://github.com/python/cpython/commit/0f274cb2d78f71073e9d7295df3b9006e7bf1097


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

Change by miss-islington :


--
pull_requests: +26548
pull_request: https://github.com/python/cpython/pull/28105

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

Change by miss-islington :


--
pull_requests: +26547
pull_request: https://github.com/python/cpython/pull/28104

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 22fe0eb13c3441b71b60aaea0e7fe289a29783da by Terry Jan Reedy in 
branch 'main':
bpo-45059: Add module cleanup to IDLE test_macosx (GH-28102)
https://github.com/python/cpython/commit/22fe0eb13c3441b71b60aaea0e7fe289a29783da


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Diego Ramirez]

Change by Diego Ramirez :


--
nosy: +DiddiLeija

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

miss-islington  added the comment:


New changeset c1db7598790d037e58cd99c06d5c166433d63322 by Miss Islington (bot) 
in branch '3.9':
bpo-45059: Fix IDLE test typo: using "==" instead of "=" (GH-28086)
https://github.com/python/cpython/commit/c1db7598790d037e58cd99c06d5c166433d63322


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

miss-islington  added the comment:


New changeset 337c8adf31c46b688a5f82bcb64dc6f1ad56703d by Miss Islington (bot) 
in branch '3.10':
bpo-45059: Fix IDLE test typo: using "==" instead of "=" (GH-28086)
https://github.com/python/cpython/commit/337c8adf31c46b688a5f82bcb64dc6f1ad56703d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +26545
pull_request: https://github.com/python/cpython/pull/28102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Definitely a typo.  Will apply fix and backport.

The first import of macosx initializes _tk_type to None.  The line in question 
intends to re-initialize it so that the subsequent assert can only pass if 
_init_tk_type changes it to something required.

Many other tests also set _tk_type as needed.  _tk_type should be restored in 
tearDownModule.  I will add that in a separate PR.  (The class cleanup already 
restores platform.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 54f100514b02f6628450043e21ccfe39350d7ac7 by Serhiy Storchaka in 
branch 'main':
bpo-45059: Fix IDLE test typo: using "==" instead of "=" (GH-28086)
https://github.com/python/cpython/commit/54f100514b02f6628450043e21ccfe39350d7ac7


--
message_count: 1.0 -> 2.0
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +26541
pull_request: https://github.com/python/cpython/pull/28098

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[miss-islington]

Change by miss-islington :


--
pull_requests: +26542
pull_request: https://github.com/python/cpython/pull/28099

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +26529
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28086

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45059] Typo: using "==" instead of "="

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

While searching for use the equality operator with None I found the possible 
use of "==" instead of "=" (assignment) in Lib/idlelib/idle_test/test_macosx.py.

for platform, types in ('darwin', alltypes), ('other', nontypes):
with self.subTest(platform=platform):
macosx.platform = platform
macosx._tk_type == None
macosx._init_tk_type()
self.assertIn(macosx._tk_type, types)

--
assignee: terry.reedy
components: IDLE, Tests
messages: 400713
nosy: serhiy.storchaka, taleinat, terry.reedy
priority: normal
severity: normal
status: open
title: Typo: using "==" instead of "="
type: behavior
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com