[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-15 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-15 Thread Diego Ramirez 


Change by Diego Ramirez :


--
nosy: +DiddiLeija

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-14 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

The bug is not a crash in the interpreter and this PR touches fundamental code 
in the interpreter, so I think the safest approach is waiting for 3.10.1

--
priority: release blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-09 Thread STINNER Victor 


STINNER Victor  added the comment:

If the change is considered as a bugfix, it can wait for the next 3.9.x and 
3.10.x release.

If it's considered as a feature (which is backward incompatible), it should 
only land in 3.10 if it's in 3.10.0, but be reverted in the 3.9 branch.

Honestly, I don't care about which option is taken, I'm just worried about the 
consistency of branches.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-09 Thread Łukasz Langa 

Łukasz Langa  added the comment:

I agree with Serhiy, I consider this a bugfix. Let's raise it to "release 
blocker" to let Pablo decide if this should wait for 3.10.1 or get bumped up to 
3.10.0.

--
nosy: +pablogsal
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-09 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

"{__module__}.{__name__}" is just incorrect reference if __name__ != 
__qualname__. Error messages should always use "{__module__}.{__qualname__}" or 
just "{__name__}". I see this as a bug. Fortunately very few code is affected.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-09 Thread STINNER Victor 


STINNER Victor  added the comment:

I reopen the issue. I'm not comfortable with the backport.

For me, this change is not a bugfix, but a new feature. It can break 
applications which rely on the exact error message in their test suite. I'm not 
sure why it was backported to Python 3.9. Moreover, I'm not comfortable to 
backport it to 3.10.1 and not 3.10.0.

I would prefer to only change the behavior in Python 3.11. If you want to get 
it in 3.10, I suggest to convince Pablo to get in 3.10.0.

Otherwise, I suggest to revert it in 3.9 and 3.10.

Well, the qualified name is usually the same than the short name, so only few 
applications should be impacted. But it's annoying when the Python behavior 
changes in a minor version (3.x.y).

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-08 Thread Irit Katriel 


Irit Katriel  added the comment:

Pablo wanted to wait for 3.10.1, see 
https://github.com/python/cpython/pull/28134#issuecomment-912679271

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-08 Thread STINNER Victor 


STINNER Victor  added the comment:

> New changeset 6b996d61c96222d959d043b9424e8125c0efbb27 by Miss Islington 
> (bot) in branch '3.10':

Pablo wrote that new changes in the 3.10 branch will only land in 3.10.1. It 
means that Python 3.10.0 and 3.10.1 will produce different exception messages. 
It is going to be an issue, no?

You should either ask for an exception to Pablo, or revert the change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-08 Thread Łukasz Langa 

Łukasz Langa  added the comment:

Thanks, Irit! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-08 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset 6b996d61c96222d959d043b9424e8125c0efbb27 by Miss Islington (bot) 
in branch '3.10':
[3.10] bpo-45083: Include the exception class qualname when formatting an 
exception (GH-28119) (GH-28134)
https://github.com/python/cpython/commit/6b996d61c96222d959d043b9424e8125c0efbb27


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-03 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset 41c23740243cc3a0699bc4d5dcfd47a0007ff039 by Miss Islington (bot) 
in branch '3.9':
[3.9] bpo-45083: Include the exception class qualname when formatting an 
exception (GH-28119) (GH-28135)
https://github.com/python/cpython/commit/41c23740243cc3a0699bc4d5dcfd47a0007ff039


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-03 Thread miss-islington 


Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +26572
pull_request: https://github.com/python/cpython/pull/28134

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-03 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset b4b6342848ec0459182a992151099252434cc619 by Irit Katriel in 
branch 'main':
bpo-45083: Include the exception class qualname when formatting an exception 
(GH-28119)
https://github.com/python/cpython/commit/b4b6342848ec0459182a992151099252434cc619


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-03 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +26573
pull_request: https://github.com/python/cpython/pull/28135

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-02 Thread STINNER Victor 


Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-01 Thread Irit Katriel 


Irit Katriel  added the comment:

I've reproduced this on 3.9 and 3.10 as well.

--
versions: +Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-01 Thread Irit Katriel 


Change by Irit Katriel :


--
title: Incorrect exception output in C -> Need to use the exception class 
qualname when rendering exception (in C code)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com