[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Łukasz Langa]

Łukasz Langa  added the comment:

The wording chosen by Terry, i.e. "Ctrl-D (end-of-file)", is pretty clear. 
Merged and fixed. Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset acd46feff3c06d3f1d00ab850e530c519445a737 by Miss Islington (bot) 
in branch '3.10':
bpo-45296: Fix exit/quit message on Windows (GH-28577) (GH-28600)
https://github.com/python/cpython/commit/acd46feff3c06d3f1d00ab850e530c519445a737


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 813fbba4cab4556e55d6044c05725a26ec20b648 by Miss Islington (bot) 
in branch '3.9':
bpo-45296: Fix exit/quit message on Windows (GH-28577) (GH-28601)
https://github.com/python/cpython/commit/813fbba4cab4556e55d6044c05725a26ec20b648


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset e649e0658ff2af87b07d994c05ae048e16e31aae by Terry Jan Reedy in 
branch 'main':
bpo-45296: Fix exit/quit message on Windows (GH-28577)
https://github.com/python/cpython/commit/e649e0658ff2af87b07d994c05ae048e16e31aae


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[miss-islington]

Change by miss-islington :


--
pull_requests: +26977
pull_request: https://github.com/python/cpython/pull/28601

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +26976
pull_request: https://github.com/python/cpython/pull/28600

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[E. Paine]

E. Paine  added the comment:

> How about "Control-D (end-of-file, a.k.a. EOF)"

I doubt beginners care that it's EOF.

> or even just "Control-D"

I'd be a lot more inclined towards this.

> IDLE uses the latter [Ctrl-D] even on Windows, and Ctrl-Z does not work.

Is it worth considering changing this behaviour? IMO Ctrl-D is better for 
consistency between platforms, but wanted to throw the idea out there for 
discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Tal Einat]

Tal Einat  added the comment:

How about "Control-D (end-of-file, a.k.a. EOF)" or even just "Control-D"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +26960
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28577

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Tal, Paine: should be use exactly the raw REPL message or something that might 
be clearer to beginners, like 'Ctrl-D (end-of-file)'?

--
nosy: +epaine, taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Terry J. Reedy]

Change by Terry J. Reedy :


--
assignee:  -> terry.reedy
components: +IDLE
type:  -> behavior
versions: +Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45296] IDLE: Change Ctrl-Z note in exit/quit repr on Windows

[Terry J. Reedy]

New submission from Terry J. Reedy :

On Windows:
>>> exit
'Use exit() or Ctrl-Z plus Return to exit'
>>> quit
'Use quit() or Ctrl-Z plus Return to exit'
>>> exit.eof
'Ctrl-Z plus Return'

On *nix, 'Ctrl-Z plus Return' is 'Ctrl-D (i.e, EOF)'
IDLE uses the latter even on Windows, and Ctrl-Z does not work.

Both exit and quit are instances of _sitebuiltins.Quitter
https://github.com/python/cpython/blob/e14d5ae5447ae28fc4828a9cee8e9007f9c30700/Lib/_sitebuiltins.py#L13-L26
class Quitter(object):
def __init__(self, name, eof):
self.name = name
self.eof = eof
def __repr__(self):
return 'Use %s() or %s to exit' % (self.name, self.eof)
def __call__ [not relevant here]

We just need to replace current exit/quit.eof as indicated above on startup.

--
messages: 402678
nosy: terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Change Ctrl-Z note in exit/quit repr on Windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com