[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, rtobar! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 92018a08240308c5beef9ccc712bef5c2e582926 by Miss Islington (bot) 
in branch '3.9':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) 
(GH-28770)
https://github.com/python/cpython/commit/92018a08240308c5beef9ccc712bef5c2e582926


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 4c35a2aa80d7f55573d83651883d8733fac01e31 by Miss Islington (bot) 
in branch '3.10':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) 
(GH-28771)
https://github.com/python/cpython/commit/4c35a2aa80d7f55573d83651883d8733fac01e31


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[miss-islington]

Change by miss-islington :


--
pull_requests: +27108
pull_request: https://github.com/python/cpython/pull/28771

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +27107
pull_request: https://github.com/python/cpython/pull/28770

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 0571b934f5f9198c3461a7b631d7073ac0a5676f by rtobar in branch 
'main':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646)
https://github.com/python/cpython/commit/0571b934f5f9198c3461a7b631d7073ac0a5676f


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Łukasz Langa]

Change by Łukasz Langa :


--
versions: +Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[Rodrigo]

Change by Rodrigo :


--
nosy: +rtobar
nosy_count: 1.0 -> 2.0
pull_requests: +27014
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/28646

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45328] http.client.HTTPConnection doesn't work without TCP_NODELAY

[R]

New submission from R :

I'm working on trying to run python under SerenityOS.

At the moment, SerenityOS doesn't implement the TCP_NODELAY socket option. This 
makes the HTTPConnection.connect() method raise an OSError for an operation 
that is otherwise optional. Additionally, the connection object can be left in 
an intermediate state: the underlying socket is always created, but depending 
on what method was invoked (either connect() directly or a higher-level one 
such as putrequest()) the connection object can be in IDLE or REQ_STARTED state.

I have a patch that works (attached), and I'll be working on submitting a PR 
now.

Usage of TCP_NODELAY was introduced in 3.5 (#23302), so even though I've been 
testing against 3.10rc2 for the time being I'm sure it will affect all versions 
in between.

--
components: Library (Lib)
files: http-client.patch
keywords: patch
messages: 402937
nosy: rtobar2
priority: normal
severity: normal
status: open
title: http.client.HTTPConnection doesn't work without TCP_NODELAY
type: behavior
versions: Python 3.10
Added file: https://bugs.python.org/file50316/http-client.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com