[issue45330] dulwich_log performance regression in 3.10

[Ken Jin]

Ken Jin  added the comment:

Considering both Inada-san and I can't repro this on Linux and Windows 
respectively, I'm closing this and blaming code placement or some magic. Thanks 
everyone.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Inada Naoki]

Inada Naoki  added the comment:

I can not confirm performance regression between 33ec88ac and 23ae2c3b.

```
Performance version: 1.0.2
Python version: 3.10.0a7+ (64-bit) revision 33ec88ac81
Report on Linux-5.4.0-81-generic-x86_64-with-glibc2.31
Number of logical CPUs: 8
Start date: 2021-10-06 13:47:33.468553
End date: 2021-10-06 13:47:52.054876

### dulwich_log ###
Mean +- std dev: 99.7 ms +- 0.9 ms

Performance version: 1.0.2
Python version: 3.11.0a0 (64-bit) revision 23ae2c3bac
Report on Linux-5.4.0-81-generic-x86_64-with-glibc2.31
Number of logical CPUs: 8
Start date: 2021-10-06 13:47:07.767177
End date: 2021-10-06 13:47:26.175560

### dulwich_log ###
Mean +- std dev: 98.6 ms +- 0.9 ms
```

--
nosy: +methane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

We use a pinned version of pyperformance so the code has not changed. I need to 
manually bump the version and when they happens I wipe all previous benchmarks

--
nosy: +pablogsal -vstinner
title: speed.python.org: dulwich_log performance regression -> dulwich_log 
performance regression in 3.10
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Ken Jin]

Ken Jin  added the comment:

Ooh thanks Irit, I hadn't considered that. I thought that versions were fixed, 
but it seems that we *do* change the 3rd party package versions once in a while.

In that time period, we bumped dulwich from 0.20.20 to 0.20.21 
https://github.com/python/pyperformance/commit/6484a40909312f373c8cfa8c05faec592288abb3.

That dulwich release had the following commits: 
https://github.com/dulwich/dulwich/compare/dulwich-0.20.21...master.

This may also explain why I couldn't see any perf regression in dulwich between 
3.10a4 and 3.10rc2 on Windows.

Once I verify this, I'll close this issue and open one on pyperformance repo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Irit Katriel]

Irit Katriel  added the comment:

Looks like this is using a 3rd party module (dulwitch.repo). Could it be a new 
version of that?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Brandt Bucher]

Change by Brandt Bucher :


--
nosy: +brandtbucher

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45330] dulwich_log performance regression in 3.10

[Ken Jin]

New submission from Ken Jin :

Somewhere between May02-May11, dulwich_log benchmark on pyperformance had a 
major performance regression on the 3.10 branch. 
https://speed.python.org/timeline/?exe=12==dulwich_log=1=200=off=on=on

For a start, we could git bisect with pyperformance. FWIW, I couldn't reproduce 
the perf regression on Windows. So it might be a Linux-only thing.

--
messages: 402955
nosy: iritkatriel, kj
priority: normal
severity: normal
status: open
title: dulwich_log performance regression in 3.10
type: performance
versions: Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com