[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2022-02-08 Thread Zachary Ware 


Zachary Ware  added the comment:

> Can issue be closed now?

I think so; if others disagree they can reopen it :)

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-12-07 Thread E. Paine 


E. Paine  added the comment:

Fix merged upstream: https://core.tcl-lang.org/tk/tktview/be8f5b9f
Can issue be closed now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-12-06 Thread Terry J. Reedy 


Terry J. Reedy  added the comment:

import tkinter as tk
tk.Menu(type='')

crashes on current Windows 3.9-11 with 8.6.12

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-12-06 Thread E. Paine 


E. Paine  added the comment:

> Any word on the tk Menu type parameter change?

I'll admit to having completely forgot about this issue and not raising it with 
the Tk team. Manually trying this case on Tk 8.6.12 segfaults, so I really need 
to raise it. To reproduce the segfault, simply run the top command in Python, 
or the bottom command in Wish:

tk.Menu(type="")
menu .m -type {}

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-11-08 Thread STINNER Victor 


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-25 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Are there changes in handling empty values for other options? If yes, we 
perhaps need to add version-dependent tests for empty values instead of just 
skipping this case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-25 Thread E. Paine 


E. Paine  added the comment:

> Any word on the tk Menu type parameter change?

I haven't submitted a bug report yet and want to do a little more research 
before I do so (the Tcl ticket system is quite difficult to search)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-25 Thread Zachary Ware 


Zachary Ware  added the comment:

Thanks for tracking that down!  Any word on the tk Menu type parameter change?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-23 Thread E. Paine 


E. Paine  added the comment:

It turns out the `test_configure_compound` change was intentional 
(https://core.tcl-lang.org/tk/tktview/46c2f088) and an empty string will use 
the value given by the style ("If set to the empty string (the default)..." 
https://www.tcl.tk/man/tcl/TkCmd/ttk_widget.html#M-compound).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-21 Thread Zachary Ware 


Zachary Ware  added the comment:

I'm not sure there's much utility to keeping this issue open: the test failures 
are fixed with a mild but not unprecedented weakening of the tests, and Tcl/Tk 
8.6.11 is in the wild and will remain there, so our tests are likely to need to 
continue handling its behavior (buggy or not) in perpetuity.

By all means, please continue pursuing the change with Tcl/Tk :).  I'm just not 
sure what else there is for us to do here.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-21 Thread Łukasz Langa 

Łukasz Langa  added the comment:

Thanks for the investigation, E. Paine. So I'm keeping this open then.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread E. Paine 


E. Paine  added the comment:

I suspect this is a bug with Tk. `-compound` accepting the empty string is not 
documented and the valid Ttk compound values listed in the source do not 
include it 
(https://github.com/tcltk/tk/blob/57451473/generic/ttk/ttkInit.c#L34-L37 - 
ignore the NULL at the end, this is required by `Tcl_GetIndexFromObjStruct`: 
https://github.com/tcltk/tcl/blob/e78868d6/generic/tclIndexObj.c#L187-L191). I 
therefore assume it must be a regression with one of the changes that was made 
to `Ttk_GetCompoundFromObj` between 8.6.10 and 8.6.11. I will investigate 
further and report it to the Tk team.

I have not fully investigated the issue with `test_configure_type` reported 
here and in bpo-43139, but again, the empty string is not documented as being 
valid.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
pull_requests: +27366
pull_request: https://github.com/python/cpython/pull/28986

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
pull_requests: +27365
pull_request: https://github.com/python/cpython/pull/29003

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset b8dbb3a7f96718dddb8bed31130f421316213dc5 by Miss Islington (bot) 
in branch '3.10':
bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077) (GH-29080)
https://github.com/python/cpython/commit/b8dbb3a7f96718dddb8bed31130f421316213dc5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset 2ce38167000fef3a71f1783acdda2a2cf7a2df39 by Miss Islington (bot) 
in branch '3.8':
bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077) (GH-29093)
https://github.com/python/cpython/commit/2ce38167000fef3a71f1783acdda2a2cf7a2df39


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset 15cd7a7f9edcc121f273ae1d8007128282f8f85f by Miss Islington (bot) 
in branch '3.9':
bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077) (GH-29081)
https://github.com/python/cpython/commit/15cd7a7f9edcc121f273ae1d8007128282f8f85f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +27363
pull_request: https://github.com/python/cpython/pull/29093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-20 Thread Łukasz Langa 

Łukasz Langa  added the comment:

Zach, yes, at least to 3.10, 3.9, and 3.8 please.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +27349
pull_request: https://github.com/python/cpython/pull/29081

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread miss-islington 


Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 8.0 -> 9.0
pull_requests: +27348
pull_request: https://github.com/python/cpython/pull/29080

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware 


Zachary Ware  added the comment:


New changeset 4fe454c6f54b0948af67b53af6c2f35af6377e69 by Zachary Ware in 
branch 'main':
bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077)
https://github.com/python/cpython/commit/4fe454c6f54b0948af67b53af6c2f35af6377e69


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware 

Zachary Ware  added the comment:

AFAICT, this is just a couple of tests that are testing something that's no 
longer an error, though anyone with deeper knowledge is more than welcome to 
disagree with my diagnosis :).  I've posted PR29077 to fix the tests.

Ned and Łukasz, will you want this backported to security branches to fix the 
buildbot(s)?

--
nosy: +lukasz.langa
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware 


Change by Zachary Ware :


--
nosy: +zach.ware
nosy_count: 6.0 -> 7.0
pull_requests: +27346
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29077

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread STINNER Victor 


Change by STINNER Victor :


--
title: test_tk.test_configure_type() failed on x86 Gentoo Non-Debug with X 3.x 
with Tcl/Tk 8.6.11 -> test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com