[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks for noticing, Ruben! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 0ff3d95b9875805ac03aeffc37ae4458ce3b8ac0 by Ruben Vorderman in 
branch 'main':
bpo-45507: EOFErrors should be thrown for truncated gzip members (GH-29029)
https://github.com/python/cpython/commit/0ff3d95b9875805ac03aeffc37ae4458ce3b8ac0


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Ruben Vorderman]

Ruben Vorderman  added the comment:

bump. This is a regression introduced by 
https://github.com/python/cpython/pull/27941

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Ruben Vorderman]

Change by Ruben Vorderman :


--
pull_requests: +27301
pull_request: https://github.com/python/cpython/pull/29029

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Ruben Vorderman]

Ruben Vorderman  added the comment:

It turns out there is a bug where FNAME and/or FCOMMENT flags are set in the 
header, but no error is thrown when NAME and COMMENT fields are missing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Ruben Vorderman]

Change by Ruben Vorderman :


--
keywords: +patch
pull_requests: +27296
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29023

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45507] Small oversight in 3.11 gzip.decompress implementation with regards to backwards compatibility

[Ruben Vorderman]

New submission from Ruben Vorderman :

A 'struct.error: unpack requires a buffer of 8 bytes' is thrown when a gzip 
trailer is truncated instead of an EOFError such as in the 3.10 and prior 
releases.

--
components: Library (Lib)
messages: 404165
nosy: rhpvorderman
priority: normal
severity: normal
status: open
title: Small oversight in 3.11 gzip.decompress implementation with regards to 
backwards compatibility
type: behavior
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com