[issue45578] Missing tests for the dis module

2022-01-26 Thread Tal Einat 


Tal Einat  added the comment:

Thanks for your work on this Nikita!

--
nosy: +taleinat
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2022-01-26 Thread Dong-hee Na 


Dong-hee Na  added the comment:


New changeset 84f093918a4be663775afe2933f4be86f72fe495 by Nikita Sobolev in 
branch 'main':
bpo-45578: add a test case for `dis.findlabels` (GH-30058)
https://github.com/python/cpython/commit/84f093918a4be663775afe2933f4be86f72fe495


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-12-11 Thread Nikita Sobolev 


Change by Nikita Sobolev :


--
pull_requests: +28278
pull_request: https://github.com/python/cpython/pull/30058

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset 8198617bcce885c280ba5f8acd066c71b311b1ac by Łukasz Langa in 
branch '3.9':
[3.9] bpo-45578: add tests for `dis.distb` (GH-29332) (#29386)
https://github.com/python/cpython/commit/8198617bcce885c280ba5f8acd066c71b311b1ac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset fd6b70d6b715c2403a194a2b3eae3210e2e81742 by Łukasz Langa in 
branch '3.10':
[3.10] bpo-45578: add tests for `dis.distb` (GH-29332) (GH-29385)
https://github.com/python/cpython/commit/fd6b70d6b715c2403a194a2b3eae3210e2e81742


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Nikita Sobolev 


Nikita Sobolev  added the comment:

Only `findlabels` tests are left!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Łukasz Langa 

Change by Łukasz Langa :


--
pull_requests: +27644
pull_request: https://github.com/python/cpython/pull/29386

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Łukasz Langa 

Change by Łukasz Langa :


--
pull_requests: +27643
pull_request: https://github.com/python/cpython/pull/29385

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-11-03 Thread Łukasz Langa 

Łukasz Langa  added the comment:


New changeset e346f196819aeb02a8a94205ce3e1536c4c2f105 by Nikita Sobolev in 
branch 'main':
bpo-45578: add tests for `dis.distb` (GH-29332)
https://github.com/python/cpython/commit/e346f196819aeb02a8a94205ce3e1536c4c2f105


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-30 Thread Joannah Nanjekye 


Joannah Nanjekye  added the comment:

Yes, it is that's why I added the clarity "It looks like it *is* actually" above

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-30 Thread Nikita Sobolev 


Nikita Sobolev  added the comment:

Looks like `findlabels` is documented: 
https://docs.python.org/3/library/dis.html#dis.findlabels

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-30 Thread Nikita Sobolev 


Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +27600
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29332

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-30 Thread Nikita Sobolev 


Nikita Sobolev  added the comment:

I would like to work on it! :)

Going to send a PR today.

--
nosy: +sobolevn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-22 Thread Joannah Nanjekye 


Joannah Nanjekye  added the comment:

It looks like it actually

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-22 Thread Joannah Nanjekye 


Joannah Nanjekye  added the comment:

maybe the latter is not a public function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for the dis module

2021-10-22 Thread Joannah Nanjekye 


Change by Joannah Nanjekye :


--
title: Missing tests for he dis module -> Missing tests for the dis module

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45578] Missing tests for he dis module

2021-10-22 Thread Joannah Nanjekye 


New submission from Joannah Nanjekye :

I don't see any tests for the following:

dis.distb
dis.findlabels

They are documented, I wonder if it was intentional.

dis.findlabels is also not dicumented.

--
components: Tests
messages: 404805
nosy: nanjekyejoannah
priority: normal
severity: normal
status: open
title: Missing tests for he dis module
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com