[issue45723] Improve and simplify configure.ac checks

[Zachary Ware]

Change by Zachary Ware :


--
components:  -2to3 (2.x to 3.x conversion tool), Argument Clinic, C API, 
Cross-Build, Demos and Tools, Distutils, Documentation, Extension Modules, 
FreeBSD, IDLE, IO, Installation, Interpreter Core, Library (Lib), Parser, 
Regular Expressions, SSL, Subinterpreters, Tests, Tkinter, Unicode, Windows, 
XML, asyncio, ctypes, email, macOS
nosy:  -Alex.Willmer, alwaysasetup, asvetlov, barry, dstufft, eric.araujo, 
ezio.melotti, koobs, larry, lys.nikolaou, miss-islington, mrabarnett, 
ned.deily, pablogsal, paul.moore, r.david.murray, ronaldoussoren, steve.dower, 
terry.reedy, tim.golden, vstinner, yselivanov, zach.ware
type: security -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Ant Man]

Change by Ant Man :


--
nosy: +alwaysasetup

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Ant Man]

Change by Ant Man :


--
components: +2to3 (2.x to 3.x conversion tool), Argument Clinic, C API, 
Cross-Build, Demos and Tools, Distutils, Documentation, Extension Modules, 
FreeBSD, IDLE, IO, Installation, Interpreter Core, Library (Lib), Parser, 
Regular Expressions, SSL, Subinterpreters, Tests, Tkinter, Unicode, Windows, 
XML, asyncio, ctypes, email, macOS
nosy: +Alex.Willmer, asvetlov, barry, dstufft, eric.araujo, ezio.melotti, 
koobs, larry, lys.nikolaou, mrabarnett, ned.deily, pablogsal, paul.moore, 
r.david.murray, ronaldoussoren, steve.dower, terry.reedy, tim.golden, vstinner, 
yselivanov, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Ant Man]

Change by Ant Man :


--
type: enhancement -> security

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 994f90c0772612780361e1dc5fa5223dce22f70a by Christian Heimes in 
branch 'main':
bpo-45723: Fix detection of epoll (#30449)
https://github.com/python/cpython/commit/994f90c0772612780361e1dc5fa5223dce22f70a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:

Thanks William!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +28654
pull_request: https://github.com/python/cpython/pull/30449

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[William Fisher]

William Fisher  added the comment:

In the conversion to PY_CHECK_FUNC, there's a mistake in HAVE_EPOLL.

Python 3.10.1 defines HAVE_EPOLL by checking for the `epoll_create` function. 
Python 3.11.0a3 checks for the `epoll` function instead. There is no epoll() 
function so this always fails.

The effect is that `epoll` doesn't exist in the `select` module on Python 
3.11.0a3. Most code that uses epoll falls back when it is not available, so 
this may not be failing any tests.

--
nosy: +byllyfish

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +28254
pull_request: https://github.com/python/cpython/pull/30029

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +28251
pull_request: https://github.com/python/cpython/pull/30026

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 74b23c97cd5e178970a199066795cf0561f46b72 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Normalise configure user communication (GH-30024)
https://github.com/python/cpython/commit/74b23c97cd5e178970a199066795cf0561f46b72


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +28248
pull_request: https://github.com/python/cpython/pull/30024

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[miss-islington]

miss-islington  added the comment:


New changeset c1dec9540ab04691f8d4a131671e069913e6eee3 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Sort the grand AC_CHECK_HEADERS check (GH-29846)
https://github.com/python/cpython/commit/c1dec9540ab04691f8d4a131671e069913e6eee3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +28075
pull_request: https://github.com/python/cpython/pull/29846

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27937
pull_request: https://github.com/python/cpython/pull/29701

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset db2277a114463d30a58d9066f2b47f7a53a1488c by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Add helpers for save/restore env (GH-29637)
https://github.com/python/cpython/commit/db2277a114463d30a58d9066f2b47f7a53a1488c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27868
pull_request: https://github.com/python/cpython/pull/29637

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset fc9b62281931da8d20f85d5ed44cfc24f068d3f4 by Christian Heimes in 
branch 'main':
bpo-45723: Add --with-pkg-config to configure (GH-29517)
https://github.com/python/cpython/commit/fc9b62281931da8d20f85d5ed44cfc24f068d3f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 76d14fac72479e0f5f5b144d6968ecd9e594db34 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Improve and simplify more configure.ac checks (GH-29485)
https://github.com/python/cpython/commit/76d14fac72479e0f5f5b144d6968ecd9e594db34


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +27769
pull_request: https://github.com/python/cpython/pull/29517

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[miss-islington]

miss-islington  added the comment:


New changeset 49171aa91ab78c2608a26e5a75cdceab3bad6176 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Remove dead code for obsolete `--with-dyld` option (GH-29500)
https://github.com/python/cpython/commit/49171aa91ab78c2608a26e5a75cdceab3bad6176


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27749
pull_request: https://github.com/python/cpython/pull/29500

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[miss-islington]

miss-islington  added the comment:


New changeset 185533639d6eddd42a28f9e3517067bd877e34c5 by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Remove obsolete AC_EXEEXT from configure.ac (GH-29486)
https://github.com/python/cpython/commit/185533639d6eddd42a28f9e3517067bd877e34c5


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

AC_CHECK_TYPE is obsolete and it's use is discouraged. There are some gotchas 
we need to check before switching to AC_CHECK_TYPES.

See:
- 
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html
- 
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Generic-Types.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27737
pull_request: https://github.com/python/cpython/pull/29486

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27736
pull_request: https://github.com/python/cpython/pull/29485

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset cbab997efb3ba5123dc8d9f706184fa8e634b3ec by Christian Heimes in 
branch 'main':
bpo-45723: Prepare support for autoconf 2.71 (GH-29441)
https://github.com/python/cpython/commit/cbab997efb3ba5123dc8d9f706184fa8e634b3ec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 9bd0cf5970997b63d296e30d51e7bb9a15dcabaf by Erlend Egeberg 
Aasland in branch 'main':
bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466)
https://github.com/python/cpython/commit/9bd0cf5970997b63d296e30d51e7bb9a15dcabaf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +27719
pull_request: https://github.com/python/cpython/pull/29466

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
nosy: +erlendaasland

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 57c50c9c7c701a8301c5a89b2b2d050550f62022 by Christian Heimes in 
branch 'main':
bpo-45723: Add helper macros and more caching to configure.ac (GH-29429)
https://github.com/python/cpython/commit/57c50c9c7c701a8301c5a89b2b2d050550f62022


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:


New changeset be3cd5c05d9fb1d1cdb55cb98ca6ef8f866774be by Christian Heimes in 
branch 'main':
bpo-45723: Detect missing pkg-config (GH-29442)
https://github.com/python/cpython/commit/be3cd5c05d9fb1d1cdb55cb98ca6ef8f866774be


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:

GH-29441 introduces forward compatibility issues with autoconf 2.71. I took the 
output of autoupdate and resolved all warnings.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +27697
pull_request: https://github.com/python/cpython/pull/29442

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +27696
pull_request: https://github.com/python/cpython/pull/29441

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +27684
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29429

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

Christian Heimes  added the comment:

The first PR adds helper macros, AC_CACHE_CHECK() [1] and AS_VAR_IF() [2]. It 
also unified internal variables to use format "ac_cv_func_$funcname", 
"ac_cv_func_lib_$library_$funcname", or "ac_cv_header_$headername_h". "ac_cv" 
stands for autoconf cached value.

AC_CACHE_CHECK() replaces AC_MSG_CHECKING() and AC_MSG_RESULT(). The syntax is 
AC_CACHE_CHECK([text], [cache variable], [body]) where body is only excecuted 
when the cache variable is not set. The body has to set the cache variable to 
yes or no. Any output and AC_DEFINE must occur outside the body.

AS_VAR_IF() is a nicer way to write if test $variable = value; then; fi.

[1] 
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Caching-Results.html#Caching-Results
[2] 
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45723] Improve and simplify configure.ac checks

[Christian Heimes]

New submission from Christian Heimes :

The autoconf-based build system has room for improvements. The configure.ac 
script can be simplified in several places by using AS and AC macros or by 
defining new custom macros.

For example we have a lot of blocks that look like this:

AC_MSG_CHECKING(for chroot)
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include ]], [[void x=chroot]])],
  [AC_DEFINE(HAVE_CHROOT, 1, Define if you have the 'chroot' function.)
   AC_MSG_RESULT(yes)],
  [AC_MSG_RESULT(no)
])

The block has an issue, too. It does not use AC_CACHE to cache the result. The 
entire block can be replaced by a custom macro that takes care of everything 
and implements correct caching:

  PY_CHECK_FUNC([chroot], [#include ])

We can also move several library and header checks from setup.py into 
configure.ac, e.g. check for soundcard.h or gdbm libs and headers.

--
assignee: christian.heimes
components: Build
messages: 405780
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Improve and simplify configure.ac checks
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com