[issue46198] Duplicate and unused code in tests

[Alex Waygood]

Change by Alex Waygood :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:


New changeset 4199b7ffbbaa5fe52a4c85c8672ac6773a75ba8f by Jelle Zijlstra in 
branch '3.10':
[3.10] bpo-46198: rename duplicate tests and remove unused code (GH-30297) 
(GH-31796)
https://github.com/python/cpython/commit/4199b7ffbbaa5fe52a4c85c8672ac6773a75ba8f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:


New changeset 4052dd2296da2ff304b1fa787b100befffa1c9ca by Alex Waygood in 
branch 'main':
bpo-46198: Fix `test_asyncio.test_sslproto` (GH-31801)
https://github.com/python/cpython/commit/4052dd2296da2ff304b1fa787b100befffa1c9ca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:


New changeset f7f7838b41d45efa129a61f104136f8e12f3488a by Jelle Zijlstra in 
branch '3.9':
[3.9] bpo-46198: rename duplicate tests and remove unused code (GH-30297) 
(GH-31797)
https://github.com/python/cpython/commit/f7f7838b41d45efa129a61f104136f8e12f3488a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Alex Waygood]

Change by Alex Waygood :


--
nosy: +AlexWaygood
nosy_count: 3.0 -> 4.0
pull_requests: +29902
pull_request: https://github.com/python/cpython/pull/31801

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Change by Jelle Zijlstra :


--
pull_requests: +29900
pull_request: https://github.com/python/cpython/pull/31797

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Change by Jelle Zijlstra :


--
pull_requests: +29899
pull_request: https://github.com/python/cpython/pull/31796

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:


New changeset 6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97 by Nikita Sobolev in 
branch 'main':
bpo-46198: rename duplicate tests and remove unused code (GH-30297)
https://github.com/python/cpython/commit/6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97


--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Nikita Sobolev]

Nikita Sobolev  added the comment:

> I think most of these are false positives

Yes, they are! Please, check out my PR:
https://github.com/python/cpython/pull/30297

сб, 1 янв. 2022 г. в 21:52, Éric Araujo :

>
> Éric Araujo  added the comment:
>
> I think most of these are false positives (it’s fine if 10 different tests
> define a function `f`), so should not be changed just to appease a lint
> tool.  Others are genuine!
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Éric Araujo]

Éric Araujo  added the comment:

I think most of these are false positives (it’s fine if 10 different tests 
define a function `f`), so should not be changed just to appease a lint tool.  
Others are genuine!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46198] Duplicate and unused code in tests

[Nikita Sobolev]

Nikita Sobolev  added the comment:

Thanks! I will also attach all `flake8`'s output if someone is going to need it:

```
» flake8 --select=F811 Lib/test
Lib/test/test_descr.py:1165:13: F811 redefinition of unused 'C' from line 1158
Lib/test/test_descr.py:1172:13: F811 redefinition of unused 'C' from line 1165
Lib/test/test_descr.py:1179:13: F811 redefinition of unused 'C' from line 1172
Lib/test/test_descr.py:1186:13: F811 redefinition of unused 'C' from line 1179
Lib/test/test_descr.py:1192:9: F811 redefinition of unused 'C' from line 1186
Lib/test/test_descr.py:1198:9: F811 redefinition of unused 'C' from line 1192
Lib/test/test_descr.py:1488:13: F811 redefinition of unused 'C' from line 1480
Lib/test/test_descr.py:1498:13: F811 redefinition of unused 'C' from line 1488
Lib/test/test_descr.py:1506:13: F811 redefinition of unused 'C' from line 1498
Lib/test/test_descr.py:1514:13: F811 redefinition of unused 'C' from line 1506
Lib/test/test_descr.py:4076:13: F811 redefinition of unused 'X' from line 4073
Lib/test/test_descr.py:4079:13: F811 redefinition of unused 'X' from line 4076
Lib/test/test_descr.py:4084:13: F811 redefinition of unused 'X' from line 4079
Lib/test/test_descr.py:4087:13: F811 redefinition of unused 'X' from line 4084
Lib/test/test_descr.py:4090:9: F811 redefinition of unused 'X' from line 4087
Lib/test/test_buffer.py:759:5: F811 redefinition of unused 'genslices' from 
line 694
Lib/test/test_buffer.py:760:5: F811 redefinition of unused 'genslices_ndim' 
from line 698
Lib/test/test_buffer.py:761:5: F811 redefinition of unused 'permutations' from 
line 20
Lib/test/test_syntax.py:1555:5: F811 redefinition of unused 
'test_break_outside_loop' from line 1525
Lib/test/test_typing.py:108:13: F811 redefinition of unused 'A' from line 105
Lib/test/test_typing.py:148:13: F811 redefinition of unused 'A' from line 145
Lib/test/test_typing.py:332:13: F811 redefinition of unused 'C' from line 329
Lib/test/test_typing.py:335:13: F811 redefinition of unused 'C' from line 332
Lib/test/test_typing.py:880:13: F811 redefinition of unused 'P' from line 877
Lib/test/test_typing.py:883:13: F811 redefinition of unused 'P' from line 880
Lib/test/test_typing.py:1385:13: F811 redefinition of unused 'P' from line 1383
Lib/test/test_typing.py:1387:13: F811 redefinition of unused 'P' from line 1385
Lib/test/test_typing.py:1389:13: F811 redefinition of unused 'P' from line 1387
Lib/test/test_typing.py:1665:13: F811 redefinition of unused 'MyGeneric' from 
line 1663
Lib/test/test_typing.py:2295:13: F811 redefinition of unused 'Subclass' from 
line 2292
Lib/test/test_typing.py:2478:13: F811 redefinition of unused 'C' from line 2475
Lib/test/test_typing.py:2522:13: F811 redefinition of unused 'C' from line 2519
Lib/test/test_typing.py:4532:5: F811 redefinition of unused 'test_hash_eq' from 
line 4475
Lib/test/test_typing.py:4652:13: F811 redefinition of unused 'C' from line 4648
Lib/test/test_typing.py:4844:13: F811 redefinition of unused 'C' from line 4841
Lib/test/datetimetester.py:1867:9: F811 redefinition of unused 'io' from line 5
Lib/test/datetimetester.py:3991:9: F811 redefinition of unused 'io' from line 5
Lib/test/test_genericclass.py:101:13: F811 redefinition of unused 'D' from line 
95
Lib/test/test_genericclass.py:114:13: F811 redefinition of unused 'D' from line 
108
Lib/test/test_subclassinit.py:235:13: F811 redefinition of unused 'MyClass' 
from line 221
Lib/test/test_subclassinit.py:246:9: F811 redefinition of unused 'MyClass' from 
line 235
Lib/test/test_subclassinit.py:268:9: F811 redefinition of unused 'MyClass' from 
line 259
Lib/test/test_tabnanny.py:7:1: F811 redefinition of unused 'mock' from line 6
Lib/test/test_compile.py:1178:5: F811 redefinition of unused 'test_func_args' 
from line 1171
Lib/test/test_dataclasses.py:517:13: F811 redefinition of unused 'A' from line 
512
Lib/test/test_dataclasses.py:527:13: F811 redefinition of unused 'A' from line 
517
Lib/test/test_dataclasses.py:681:21: F811 redefinition of unused 'Point' from 
line 672
Lib/test/test_dataclasses.py:692:21: F811 redefinition of unused 'Point' from 
line 681
Lib/test/test_dataclasses.py:702:17: F811 redefinition of unused 'C' from line 
697
Lib/test/test_dataclasses.py:1840:9: F811 redefinition of unused 'C' from line 
1834
Lib/test/test_dataclasses.py:2387:13: F811 redefinition of unused 'C' from line 
2378
Lib/test/test_dataclasses.py:2396:13: F811 redefinition of unused 'C' from line 
2387
Lib/test/test_dataclasses.py:2405:13: F811 redefinition of unused 'C' from line 
2396
Lib/test/test_dataclasses.py:2778:13: F811 redefinition of unused 'C' from line 
2770
Lib/test/test_dataclasses.py:2784:9: F811 redefinition of unused 'C' from line 
2778
Lib/test/test_dataclasses.py:3678:13: F811 redefinition of unused 'A' from line 
3673
Lib/test/test_dataclasses.py:3683:13: F811 redefinition of unused 'A' from line 
3678
Lib/test/test_dataclasses.py:3825:13: F811 redefinition of unused 'A' from line 
3816
Lib/test/test_dataclasses.p