[issue46219] except* assumes that an exception group is truthy

2022-01-02 Thread Irit Katriel


Change by Irit Katriel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46219] except* assumes that an exception group is truthy

2022-01-02 Thread Irit Katriel


Irit Katriel  added the comment:


New changeset 65e7c1f90e9136fc61f4af029b065d9f6c5664c3 by Irit Katriel in 
branch 'main':
bpo-46219, 46221: simplify except* implementation following exc_info changes. 
Move helpers to exceptions.c. Do not assume that exception groups are truthy. 
(GH-30289)
https://github.com/python/cpython/commit/65e7c1f90e9136fc61f4af029b065d9f6c5664c3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46219] except* assumes that an exception group is truthy

2022-01-02 Thread Vedran Čačić

Vedran Čačić  added the comment:

A long time ago, Python documentation used true and false as adjectives (as 
opposed to True and False, which are proper names for canonical true/false 
objects). I think it was BDFL's preference back then.

In the meantime, I suppose through JS's influence, Python documentation started 
to adopt ancient Perl terminology, where truhy and falsy were used as 
adjectives standing for what was previously known as true and false. I really 
don't like it, and I think English language is clear enough here (given the 
help of code font and capital letter) that we don't need to invent new words. 
Of course, it is up to the community to decide (and maybe the steering council 
might issue an opinion), but I'm telling you the history and my preference.

--
nosy: +veky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46219] except* assumes that an exception group is truthy

2022-01-01 Thread Irit Katriel


Irit Katriel  added the comment:

... "for falsy ExceptionGroup subclasses"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46219] except* assumes that an exception group is truthy

2022-01-01 Thread Irit Katriel


Change by Irit Katriel :


--
keywords: +patch
pull_requests: +28538
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30289

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46219] except* assumes that an exception group is truthy

2022-01-01 Thread Irit Katriel


Change by Irit Katriel :


--
title: except* assumes that an exception group is truth -> except* assumes that 
an exception group is truthy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com