[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[miss-islington]

miss-islington  added the comment:


New changeset 95b70e2ccfb295c77c3696bcb20c1513310efd1f by Miss Islington (bot) 
in branch '3.10':
bpo-46530: add `"thread_time"` to `test_time.test_get_clock_info` (GH-30913)
https://github.com/python/cpython/commit/95b70e2ccfb295c77c3696bcb20c1513310efd1f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[miss-islington]

miss-islington  added the comment:


New changeset ce5c637f5ae06f2a6a6e966524af9d0cc816bd3f by Miss Islington (bot) 
in branch '3.9':
bpo-46530: add `"thread_time"` to `test_time.test_get_clock_info` (GH-30913)
https://github.com/python/cpython/commit/ce5c637f5ae06f2a6a6e966524af9d0cc816bd3f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +29156
pull_request: https://github.com/python/cpython/pull/30977

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[miss-islington]

Change by miss-islington :


--
pull_requests: +29157
pull_request: https://github.com/python/cpython/pull/30978

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[Nikita Sobolev]

Nikita Sobolev  added the comment:

Thank you!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset c27a33132be101e246ae2584f1826477357138d6 by Nikita Sobolev in 
branch 'main':
bpo-46530: add `"thread_time"` to `test_time.test_get_clock_info` (#30913)
https://github.com/python/cpython/commit/c27a33132be101e246ae2584f1826477357138d6


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[Nikita Sobolev]

Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +29092
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30913

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46530] `'thread_time'` is missing from `test_get_clock_info`

[Nikita Sobolev]

New submission from Nikita Sobolev :

Right now here's how `test_get_clock_info` looks like:

```
def test_get_clock_info(self):
clocks = ['monotonic', 'perf_counter', 'process_time', 'time']

for name in clocks:
info = time.get_clock_info(name)

#self.assertIsInstance(info, dict)
self.assertIsInstance(info.implementation, str)
self.assertNotEqual(info.implementation, '')
self.assertIsInstance(info.monotonic, bool)
self.assertIsInstance(info.resolution, float)
# 0.0 < resolution <= 1.0
self.assertGreater(info.resolution, 0.0)
self.assertLessEqual(info.resolution, 1.0)
self.assertIsInstance(info.adjustable, bool)
```

It tests for out of five possible arguments to `time.get_clock_info`.
Docs: https://docs.python.org/3/library/time.html#time.get_clock_info
`'thread_time'` is missing for some reason.

I think we should add it to the test.

Link: 
https://github.com/python/cpython/blob/7cf285d82ec722d4225297366013e924805171f2/Lib/test/test_time.py#L559

PR is incoming.

--
components: Tests
messages: 411717
nosy: sobolevn
priority: normal
severity: normal
status: open
title: `'thread_time'` is missing from `test_get_clock_info`
type: behavior
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com