[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou added the comment:

I suppose this can be closed now.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou added the comment:


New changeset bd73e72b4a9f019be514954b1d40e64dc3a5e81c by Antoine Pitrou (Allen 
W. Smith, Ph.D) in branch 'master':
bpo-5001: More-informative multiprocessing error messages (#3079)
https://github.com/python/cpython/commit/bd73e72b4a9f019be514954b1d40e64dc3a5e81c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

drallensmith added the comment:

I've updated the PR to include all of the non-Windows-specific asserts; I am 
not sufficiently familiar with Windows multiprocessing to feel confident 
writing informative error messages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

drallensmith added the comment:

Sorry! I was starting to wonder if the PR had been overlooked somehow...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou added the comment:

Please allow us a bit of time :-)  We are all volunteers here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

drallensmith added the comment:

No discussion yet on pull request (5 days); just submitted fixes for util.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

drallensmith added the comment:

Pull request submitted (4 days ago) for managers.py, queue.py; just added 
pool.py changes to those.

--
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

Changes by drallensmith :


--
pull_requests: +3120

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou added the comment:


New changeset 48d9823a0ebde4dfab8bc154bb6df462fb2ee403 by Antoine Pitrou (Allen 
W. Smith, Ph.D) in branch 'master':
bpo-5001, bpo-31169: Fix two uninformative asserts in 
multiprocessing/managers.py (#3078)
https://github.com/python/cpython/commit/48d9823a0ebde4dfab8bc154bb6df462fb2ee403


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

Changes by drallensmith :


--
pull_requests: +3117

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

drallensmith added the comment:

Patches (for 2.7 and 3.5; the code is identical, only the line numbers changed) 
for the portion I commented on can be found in issue 31169.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou added the comment:

@drallensmith, the patch you commented on is very old and probably doesn't 
apply anymore.  It would be useful to make an updated patch (or rather PR, as 
we are using Github for development now: see 
https://devguide.python.org/pullrequest/).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[drallensmith]

Changes by drallensmith :


--
nosy: +drallensmith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Camilla Montonen]

Changes by Camilla Montonen :


--
nosy: +Winterflower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
type:  -> enhancement
versions: +Python 3.6 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Jessica McKellar]

Jessica McKellar added the comment:

Thanks for the patches, vladris!

I've reviewed the latest version, and it addresses all of Antoine's review 
feedback. Ezio left some additional feedback 
(http://bugs.python.org/review/5001/#ps3407) which still needs to be addressed.

--
nosy: +jesstess

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
nosy: +sbt
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Vlad Riscutia]

Vlad Riscutia riscutiav...@gmail.com added the comment:

I attached a patch which replaces all asserts with checks that raise 
exceptions. I used my judgement in determining exception types but I might have 
been off in some places. Also, this patch replaces ALL asserts. It is possible 
that some of the internal functions should be kept using asserts but I am not 
familiar enough with the module to say which. I figured I'd better do the whole 
thing than reviewers can say where lines should be reverted to asserts.

--
keywords: +patch
nosy: +vladris
Added file: http://bugs.python.org/file23298/issue5001.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

Thank you. I've attached some comments, click on the review link to read them.

--
assignee: jnoller - 
nosy: +pitrou -BreamoreBoy
stage: needs patch - patch review
versions: +Python 3.3 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Vlad Riscutia]

Vlad Riscutia riscutiav...@gmail.com added the comment:

Thanks for the quick review! I attached second iteration addressing feedback + 
changed all occurrences of checks like type(x) is y to isinstance(x, y).

I would appreciate a second look because this patch has many small changes and 
even though I ran full test suit which passed, I'm afraid I made a typo 
somewhere :)

--
Added file: http://bugs.python.org/file23302/issue5001_v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

@Jesse: could you provide a patch that addresses this issue?

--
nosy: +BreamoreBoy
stage:  - needs patch
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Jesse Noller]

Jesse Noller jnol...@gmail.com added the comment:

@Mark Yeah - I'm the current multiprocessing maintainer. If I fix it, I'll just 
commit it :) I filed this as a to do against myself.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Jesse Noller]

New submission from Jesse Noller jnol...@gmail.com:

Right now, the multiprocessing code is littered with statements like:

assert self._popen is None, 'cannot start a process twice'
assert self._parent_pid == os.getpid(), \
   'can only start a process object created by current 
process'
assert not _current_process._daemonic, \
   'daemonic processes are not allowed to have children'

These will obviously be stripped out if running in optimized mode - 
however its not cool to rely on these anyway, the code should be 
refactored to proper checks, e.g.:

if not hasattr(lock, 'acquire'):
raise AttributeError('%r' has no method 'acquire' % lock)

--
assignee: jnoller
components: Library (Lib)
messages: 80192
nosy: jnoller
priority: normal
severity: normal
status: open
title: Remove assertion-based checking in multiprocessing
versions: Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com