[issue5094] datetime lacks concrete tzinfo implementation for UTC
Changes by Éric Araujo mer...@netwok.org: -- resolution: accepted - fixed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Reopening to add some minor fixes to tests and documentation. See issue5094h.diff. Ezio, thanks for finding these issues. -- status: closed - open Added file: http://bugs.python.org/file17676/issue5094h.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Éric Araujo mer...@netwok.org added the comment: +1 for replacing math range notation with English. Much easier for non-math people that do Python :) One more nit: Your docstrings use verb forms like “Returns” where PEP 257 advises to use “Return”: “[the docstring] prescribes the function or method's effect as a command (Do this, Return that), not as a description; e.g. don't write Returns the pathname ...” -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: What about .. method:: datetime.utcoffset() If :attr:`tzinfo` is ``None``, returns ``None``, else returns ... Should this use return too? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Éric Araujo mer...@netwok.org added the comment: .. method:: datetime.utcoffset() Return ``None`` if :attr:`tzinfo` is ``None``, else else return ... That said, to keep diffs readable, perhaps stick with the existing convention know, and later a PEP 257 compliance diff can be made. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: How to specify offset range horse got its beating above. See msg107554. The current wording is the best compromise between verbosity and precision. Replacing the patch with one that fixes other nits. -- Added file: http://bugs.python.org/file17680/issue5094h.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: Removed file: http://bugs.python.org/file17676/issue5094h.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Éric Araujo mer...@netwok.org added the comment: Suggestion for one line: “The *dt* argument must be aware with ``tzinfo`` set to ``self``.” “The *dt* argument must be an aware datetime, with ``tzinfo`` set to ``self``.” If there is a reST construct for aware datetime, use it. Since “self” is not special, perhaps an alternate wording like “the timezone instance from which the method is called”, but less ugly. Some PyDoc_STR calls still use “Returns.” By the way, you could have committed the unittest changes directly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
anatoly techtonik techto...@gmail.com added the comment: Good job. Thanks for working on this. It is possible to backport this to future of Python 2.7? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Antoine Pitrou pit...@free.fr added the comment: It is possible to backport this to future of Python 2.7? No. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On this happy note, I am closing this issue. Doc changes have been committed in r82004, test changes in r82003. For repr(timezone(..)) development, please follow issue #9000. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Committed in r81981. I'll open a separate documentation issue to update Doc/includes/tzinfo-examples.py and improve TZ related documentation. -- stage: patch review - committed/rejected status: open - closed title: datetime lacks concrete tzinfo impl. for UTC - datetime lacks concrete tzinfo implementation for UTC ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5094] datetime lacks concrete tzinfo implementation for UTC
Brett Cannon br...@python.org added the comment: Thanks for sticking with this, Alexander. I realized I was a slight pain to deal with on this one. =) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5094 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
