[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Brett Cannon br...@python.org added the comment: New patch updated to at least r80476. -- Added file: http://bugs.python.org/file17080/subprocess_shutdown.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by Brett Cannon br...@python.org: Removed file: http://bugs.python.org/file16976/subprocess__del__.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Gregory P. Smith g...@krypto.org added the comment: i don't see your attachment brett. -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Brett Cannon br...@python.org added the comment: Let's try this again... -- Added file: http://bugs.python.org/file16976/subprocess__del__.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Brett Cannon br...@python.org added the comment: Attached is a patch I wrote entirely independently of this issue (Mercurial's test suite trigger it for me). I go further in terms of caching items than the original patch as I still got failures even when I stored just a reference to os (might be an OS X thing with the os module). I just need someone to verify my patch works under Windows. If someone can do that I will commit it and Gabriel's test (with Antoine's suggested fixes). -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
tormen tor...@gmx.net added the comment: I ran into the same problem today :( The patch resolved it :) BUT: Could anyone comment on when this patch will or will not live?! ... As the bug is fairly old and already has duplicates and everyone seems to agree on the issue. ... Plus it seems easy enough to edit the patch to include the try: / finally: and to incorporate the remove_stderr_debug_decorations() suggestion. -- nosy: +tormen ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by Florent Xicluna florent.xicl...@gmail.com: -- nosy: +flox versions: +Python 3.2 -Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Antoine Pitrou pit...@free.fr added the comment: By the way, stderr will contain [XXX refs] as the last line with Python compiled in debug mode. The remove_stderr_debug_decorations() function will help you ignore this line. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
A.M. Kuchling li...@amk.ca added the comment: Gabriel: could you please update the patch to take Antoine's comment into account? -- nosy: +akuchling ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by Brian Curtin cur...@acm.org: -- keywords: +needs review priority: - normal stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Antoine Pitrou pit...@free.fr added the comment: There should be a try/finally in test_issue5099 to ensure that os.remove(fname) always gets called. Otherwise, looks good. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by Hans L h...@velum.net: -- nosy: +hozn ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment: At interpreter shutdown, the module's global variables are set to None before the module itself is released. __del__ methods may be called in those precaries circumstances, and should not rely on any global state. A temporary fix would be to make Popen._internal_poll and Popen._handle_exitstatus keep a reference to the os module (just add a default argument os=os, like sys=sys in __del__). But this is just a hack; the real fix would be to avoid defining __del__ at all. A patch for subprocess.py is attached. -- components: +Library (Lib) keywords: +patch nosy: +gagenellina Added file: http://bugs.python.org/file12901/subprocess.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment: Patch and test case against trunk -- versions: +Python 2.7, Python 3.0, Python 3.1 Added file: http://bugs.python.org/file12902/test_subprocess.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by Mary Stern maryst...@yahoo.com: -- title: subprocess.POpen.__del__() AttribuetError (os module == None!) - subprocess.POpen.__del__() AttributeError (os module == None!) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)
Changes by David W. Lambert lamber...@corning.com: -- nosy: +LambertDW ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5099 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
