[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Lisandro Dalcin dalc...@gmail.com added the comment: Mark, here you have a patch. I've only 'make test' on a 32bit Linux box Just two comments: - in docs: perhaps the 'versionchanged' stuff should be added. - in tests: I did not touch Modules/_testcapimodule.c, as it seems the test is covered. However, note that in all these tests, actual exception types are not checked) -- keywords: +patch Added file: http://bugs.python.org/file13010/negative-to-unsigned.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: Thanks for the patch! I agree that the 'versionchanged' reference should be added in the docs. I also think that the test should be updated to check the exception type. Here's a modified version of your patch that adds a test for OverflowError to the capi tests, adds 'versionchanged', and rewords the docs slightly. I also took the liberty of rewording the docs for PyLong_AsLongLong, to match. I've tested this on a 64-bit linux machine, and checked that the docs build properly. I'll test on 32-bit and 64-bit OS X later today. Lisandro, does this updated patch work for you? Added file: http://bugs.python.org/file13012/negative-to-unsigned2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Lisandro Dalcin dalc...@gmail.com added the comment: It worked for me. BTW, 'make test' did not noticed the change in Modules/testcapi_long.h, which is #include'd by Modules/_testcapimodule.c. I've attached a trivial patch for setup.py fixing the dependency issue. Added file: http://bugs.python.org/file13014/setup.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: Committed, r69498 (trunk) and r69499 (py3k). ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: ...and your patch for setup.py applied in r69500, r69501, r69502, r69503. Thank you! -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: However, I would like to wait until Tim comments on this. You may be in for a long wait! I hesitate to make the heretical suggestion that there may be more important things in life than fixing minor inconsistencies in Python, but I think it's possible that Tim has found some. :-) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: This also affects 3.1. Note that the current behaviour (or rather, its effects in PyLong_AsUnsignedLongLong) is as documented. In http://docs.python.org/dev/c-api/long.html it says for PyLong_AsUnsignedLongLong: Return a C unsigned long long from a Python long integer. If pylong cannot be represented as an unsigned long long, an OverflowError will be raised if the value is positive, or a TypeError will be raised if the value is negative. ...which suggests that the choice of TypeError was intentional. It still seems wrong to me, though: the argument has the correct type, but an illegal value, so ValueError or (for consistency with the other methods) OverflowError would seem more appropriate. If this change is made, then test_struct needs fixing: the change affects the 'Q' struct format. I don't think the change in struct behaviour is serious, since there's very little consistency between different struct types at the moment: for negative ints, 'Q' raises an error, 'L' and 'I' give a DeprecationWarning, and 'H' raises a struct.error. -- priority: - normal versions: +Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Mark Dickinson dicki...@gmail.com added the comment: Looks like this was changed in a checkin by Tim Peters in r21099; before r21099, PyLong_AsUnsignedLongLong raised OverflowError for negative numbers. After the checkin, it raised TypeError. I suspect the change was inadvertent. Tim, any comments? Lisandro, do you have any interest in contributing a patch for this? The patch should change the exception type, fix the docs, add a test or two for the fixed behaviour of PyLong_AsUnsignedLongLong to Modules/_testcapimodule.c, and fix the test_struct test for the 'Q' format code. -- nosy: +tim_one ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Lisandro Dalcin dalc...@gmail.com added the comment: I can contribute a patch. However, I would like to wait until Tim comments on this. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
Changes by Mark Dickinson dicki...@gmail.com: -- assignee: - marketdickinson nosy: +marketdickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5175 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5175] negative PyLong - C unsigned integral, TypeError or OverflowError?
New submission from Lisandro Dalcin dalc...@gmail.com:
At Objects/longobject.c, in almost all cases
OverflowError is raised when a unsigned integral is requested from a
negative PyLong. However, this one breaks the rules:
int
_PyLong_AsByteArray(PyLongObject* v,
unsigned char* bytes, size_t n,
int little_endian, int is_signed)
{
...
if (!is_signed) {
PyErr_SetString(PyExc_TypeError,
can't convert negative long to
unsigned);
return -1;
}
...
}
--
components: Interpreter Core
messages: 81316
nosy: dalcinl
severity: normal
status: open
title: negative PyLong - C unsigned integral, TypeError or OverflowError?
type: behavior
versions: Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5175
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
