[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Ned Deily n...@acm.org added the comment: Backported to 2.7 in r88090 (to appear in 2.7.2). (I decided to not backport to 3.1 as some prereq backports would be needed and we do not supply a 64-bit OS X installer for 3.1.x anyway.) -- assignee: ronaldoussoren - ned.deily resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: Ned--thank you for reviewing, testing, and modifying the patch. I applied your revised version to my new install of Python 2.7.1 and it works fine. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Georg Brandl ge...@python.org added the comment: I've committed in the py3k branch as r87394, so that this can get testing during beta, although your list of test systems looks quite exhaustive already. Lowering priority and leaving open for the backports. -- priority: release blocker - critical ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Ned Deily n...@acm.org added the comment: Thank you very much for the patch. I have updated it and modified it somewhat to work with the latest tip for py3k (3.2b1), 3.1.3+, and 2.7.1+ and to work with both AquaTk Cocoa 8.5 and preserve current behavior with legacy AquaTk Carbon 8.4. Since there are no automated tests for IDLE in the standard library and since the issues here had to do with differences in menu cascades and options, I created a program to introspect IDLE menus using the OS X GUI Scripting interface via py-appscript. That allowed me to semi-automatically capture the menu configurations for the IDLE configurations of interest (in particular, Apple-supplied Tk vs ActiveState Tk). The following Tcl/Tk configurations - all currently, or shortly to be, supported by python.org installers - were tested: OS X Tcl/Tk == 10.6 64-bit ActSt 8.5.9 Cocoa 10.6 64-bit Apple 8.5.7 Cocoa 10.6 32-bit ActSt 8.4.19 Carbon 10.6 32-bit Apple 8.4.19 Carbon 10.5 32-bit ActSt 8.4.19 Carbon 10.5 32-bit Apple 8.4.7 Carbon 10.4 32-bit ActSt 8.4.19 Carbon 10.4 32-bit Apple 8.4.7 Carbon 10.3 32-bit ActSt 8.4.19 Carbon Each of those Tcl/Tk configurations was tested with both IDLE.app and bin/idle, each with both py3k(3.2b1+) and 2.7.1+ builds, and each of those with both IDLE Editor windows and IDLE shell windows (they have somewhat different menu configurations). Note that testing on 10.3 was much more limited since appscript, and hence the menutester, is not supported there. Also no regressions were noted when applied to 3.1.3+ in a 32-bit only build. So far, the recently available ActiveState 64-bit Cocoa Tcl/Tk 8.5 has proven to be much more stable than the Apple-supplied 8.5 version in 10.6, which had rendered the 64-bit versions of IDLE virtually unusable up to now. With the final patches applied, I found no regressions in the menu cascades for IDLE.app. When running bin/idle (from the command line), there is a slight difference when using Cocoa Tk vs Carbon Tk. Both variants of AquaTk automatically supplies the application names from the app bundle plist. Because of the way bin/idle is structured today, the app name appears as Python rather than IDLE. With Cocoa Tk, that appears in a couple more menu items (About app and app Help) than it already does with Carbon Tk. While that would be nice to fix at some point, it is an existing cosmetic issue and I assume most inexperienced users will use IDLE.app, where there is no discrepancy. I believe this fix is ready to be applied and should go into 3.2 (and as soon as possible released for 2.7) in conjunction with building the 64-bit OS X installer to allow use of the ActiveState Cocoa 8.5. This will fix a number of reported problems with the broken IDLE with previous 64-bit OS X installers. Still to be done prior to release is updating the installer README and documenting a few minor issues. A longer-term issue is to make the menu introspection tests automatic enough to be added to the standard tests as an optional OS X test. -- assignee: ned.deily - ronaldoussoren nosy: +benjamin.peterson, georg.brandl priority: normal - release blocker stage: - patch review Added file: http://bugs.python.org/file20096/issue6075_py3k.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Ned Deily n...@acm.org: Added file: http://bugs.python.org/file20097/issue6075_27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Ned Deily n...@acm.org: -- assignee: - ned.deily nosy: +ned.deily versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: Apparently the extra menu entries are related to an Appkit bug on Leopard that Tk-Cocoa picks up; the bug is not present on Snow Leopard and won't be fixed on Leopard. As a result, I've closed the SF bug. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: Re: msg 93821, the comment about redundant entries being appended to a menu when an EditorWindow is destroyed: I've reproduced this behavior in Tk-Cocoa itself, and have concluded it's not an issue with IDLE (or my patches). I've filed bug https://sourceforge.net/tracker/? func=detailatid=112997aid=2876709group_id=12997 at SF to address this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Ronald Oussoren ronaldousso...@mac.com added the comment: I have tried to apply the patches to python's trunk, but they don't apply cleanly at all. Could you please rework the patches into a single larger patch that applies to the trunk. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: Single revised diff, tkcocoa.diff, attached, applied against Python trunk. Have not tested against Python trunk, nor do I believe it solves the issue with the extra menu items appearing when a window is closed. But hopefully this will apply more cleanly. -- Added file: http://bugs.python.org/file15096/tkcocoa.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: I've run into an additional problem with these patches. While they correctly set up the menus for Python Shell and editor windows, when a front-most window is closed, the menubar suddenly displays duplicate entries (for Edit, Run, and Help) at the end of the menubar, not all of which work correctly. Subsequent closing of other windows causes more duplication of menu entries. I have looked at every line of these patches, as well as some additional points in idlelib, and I cannot find what is causing the issue. As a result, I don't know where to fix it. If others are able to reproduce this bug after applying the patches and can find where the problem is occurring, suggestions (or a fix) are welcome. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Ronald Oussoren ronaldousso...@mac.com added the comment: I'm about to test the patches on a 10.4 system with Tk 8.4 and will report back with the results. These patches might be useful to issue 6864, that issue says IDLE blocks on 10.6 and that problem seems to be fixed in python-trunk + Kevin's patches (although I haven't tested the trunk without these patches). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Ronald Oussoren ronaldousso...@mac.com added the comment: The patches look acceptable on first glance. Which configurations of Tk have you tested? IMHO IDLE should work with the following configurations: * Tk.framework as supplied with OSX 10.4, 10.5 and 10.6 * The current releases of Tk 8.4 and 8.5 installed in /Library/Frameworks * Tk-Cocoa -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: Tested against Tk-Cocoa (the build of Tk-8.5 that comes with Snow Leopard; I also have my own build on Leopard) and Tk-Carbon 8.5 on Leopard/10.5, and it works as expected. I no longer have any builds of 8.4 to test against. The code defaults to the current behavior of Tk-Carbon if a Cocoa build is not detected. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: -- nosy: +ronaldoussoren ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: Removed file: http://bugs.python.org/file14031/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: additional refinement to help_dialog command, makes menu consistent -- Added file: http://bugs.python.org/file14035/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: Removed file: http://bugs.python.org/file14035/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: typo in macosxSupport.patch--fixed -- Added file: http://bugs.python.org/file14036/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
New submission from Kevin Walzer wordt...@users.sourceforge.net: In version 8.6 of Tk (now in beta stage), Tk on OS X will be built on top of the Cocoa API, replacing the deprecated Carbon API. Tk-Cocoa implements some UI behaviors (help menu, application menu) differently than Tk- Carbon. The attached files patch IDLE to detect whether Tk is built on top of Cocoa or Carbon, and implement the correct UI behavior. -- components: IDLE files: EditorWindow.patch keywords: patch messages: 88139 nosy: wordtech severity: normal status: open title: Patch for IDLE/OS X to work with Tk-Cocoa type: behavior versions: Python 2.6 Added file: http://bugs.python.org/file14026/EditorWindow.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: Added file: http://bugs.python.org/file14027/Bindings.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: Added file: http://bugs.python.org/file14028/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: These patches were tested on Python/IDLE 2.6.2 and Tk version 8.5.7. My build of Tk, which runs on top of Cocoa, is based on a fork of Tk hosted at http://github.com/das/tcltk/tree/de-carbon-8-5. Tk-Cocoa will become the main line for Mac OS X in Tk 8.6, now in beta. I have not tested these patches with a standard build of Tk-Carbon, but the patches default to the current IDLE behavior if Tk-Cocoa is not detected. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Kevin Walzer wordt...@users.sourceforge.net added the comment: This updated patch of macosxSupport.py adds a fix that addresses the preferences dialog, see http://bugs.python.org/issue5232. -- Added file: http://bugs.python.org/file14031/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6075] Patch for IDLE/OS X to work with Tk-Cocoa
Changes by Kevin Walzer wordt...@users.sourceforge.net: Removed file: http://bugs.python.org/file14028/macosxSupport.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
