[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Serhiy Storchaka added the comment: I have opened a new issue16760 for regex HOWTO. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Georg Brandl ge...@python.org added the comment: Should be fixed now in r83218. I've removed the class directives, and put generic class name substitutes regex and pattern in the method descriptions, like we do for contextmanager.__enter__. I've also removed the compatibility info, and removed [] style arguments where feasible. -- assignee: brian.curtin - georg.brandl resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Terry J. Reedy tjre...@udel.edu added the comment: I believe these patches are wrong, at least in part, and should be reverted. 1.The re module no longer has either a class RegexObject or a class MatchObject. (They are now _sre.SRE_Pattern and _sre.SRE_Match.) So the previous reference to them as anonymous Compiled regular expression objects and Match objects (lower case 'objects') was correct, certainly more correct that marking the fake names as real code. In other words. 'MatchObject' should be removed, not hyperlinked. This issue came up today on python-list when someone tried help(re.MatchObject) and got a module attribute error. I was about to open a new issue when I discovered this one. I recommend changing the re.match entry from return a corresponding MatchObject instance. to return a match object (which is what the current doc string says) and removing all the misleading RegexObject and MatchObject fake-class method prefixes, The prefixes are present in 2.6 and already removed in 2.7. I think they should also be removed from the 3.x docs. (Unless, of course, re is changed to add/reinstate those names, which could only happen in 3.2.) 2. I believe it is the policy that the 3.x docs 'start fresh' with 3.0. Ancient back-compatibility notes like (Incompatibility note: in the original Python 1.5 release, if the tuple was one element long, a string would be returned instead. In later versions (from 1.5.1 on), a singleton tuple is returned in such cases.) were intentionally, not accidentally, removed in 3.0. So I think it a mistake to put revert the removal and that the reversion should be reverted. 3. This is more of a question. I have noticed that optional parameters with defaults are sometimes bracketed and sometimes not. Since the brackets are redundant, I prefer without as less cluttered and so I question the addition in the 3.2 patch. But is there a definitive current doc style guide? In any case, removing the default value while changing 'group=0' to '[group]' seems wrong. -- assignee: brian.curtin - christian.heimes nosy: +christian.heimes, tjreedy resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Brian Curtin cur...@acm.org added the comment: I'm guessing assigning to Christian was accidental - taking it back for myself. -- assignee: christian.heimes - brian.curtin priority: low - normal stage: committed/rejected - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Brian Curtin cur...@acm.org added the comment: How does this patch look? It changes RegexObject to _sre.SRE_Pattern and MatchObject to _sre.SRE_Match. Additionally, references are used to link to those classes generically as match objects or compiled regular expressions rather than the fake classes used before. -- stage: - patch review Added file: http://bugs.python.org/file18245/issue6538_corrections.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Ezio Melotti ezio.melo...@gmail.com added the comment: The patch looks good to me, but I'm not sure if it's a good idea to use _sre.SRE_*. I think these are implementation details and even if they should be mentioned somewhere, they clutter the doc IMHO. 2. I believe it is the policy that the 3.x docs 'start fresh' with 3.0. Yes, they should be removed. 3. [...] In any case, removing the default value while changing 'group=0' to '[group]' seems wrong. If it's possible to specify a default value the [] should be avoided. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Brian Curtin cur...@acm.org added the comment: I didn't actually want to use _sre.SRE_* but I'm not exactly sure how to hide it. It's more correct that way, but it takes this issue the wrong direction by exposing it. I think it should be denoted as a class but with a generic name, if that's even possible. It would actually be nice if the lines class _sre.* were just invisible. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
R. David Murray rdmur...@bitdance.com added the comment: Please note that my original suggestion was to make them *section* links (:ref:s). As Terry says, they are not real classes and should not be marked up as such. Nor should the internal class names be exposed. Terry: [] notation is 2.x, they should all be gone (with the possible exception of a few C functions) in the 3.x docs. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Brian Curtin cur...@acm.org added the comment: Fixed in trunk (r79430), release26-maint (r79631), py3k (r79434), and release31-maint (r79435). Thanks for the patch. -- assignee: georg.brandl - brian.curtin resolution: - fixed stage: needs patch - committed/rejected status: open - closed type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Asheesh Laroia ashe...@asheesh.org added the comment: Er, ignore my comment then! If this is reviewed, can it get committed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Asheesh Laroia ashe...@asheesh.org added the comment: Hey Ryan, I took a look at the diff you attached here. It looks like you did There are some whitespace-only changes -- for example, you remove and then re-insert the line beginning with The name of the last matched capturing group. Can you re-submit your most recent patch without the unneeded whitespace-only changes? There's a light at the end of the tunnel! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Brian Curtin cur...@acm.org added the comment: I've reviewed the patch and do not see any unnecessary whitespace changes in his patch. -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Changes by Ryan Arana ryan.ar...@gmail.com: Removed file: http://bugs.python.org/file16274/MatchObjectLinksFix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Ryan Arana ryan.ar...@gmail.com added the comment: I tried to format the methods of the class(es) as they are formatted in other files, which is why I added the whitespace. I can go back and remove that if that's what would be preferred. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Ryan Arana ryan.ar...@gmail.com added the comment: Added .. class:: MatchObject and .. class:: RegexObject directives. -- Added file: http://bugs.python.org/file16427/MatchObjectLinksFix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Asheesh Laroia ashe...@asheesh.org added the comment: Hey all, I think this is ready. Can someone review the patch? -- nosy: +Asheesh.Laroia ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: It would be simpler to add a .. class:: MatchObject directive. Also, RegexpObject should be handled as well. -- nosy: +amaury.forgeotdarc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Asheesh Laroia ashe...@asheesh.org added the comment: Ryan -- would you take a further look at this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
Ryan Arana ryan.ar...@gmail.com added the comment: Changed all occurrences of :class:`MatchObjects` to :ref:`match-objects` in /Doc/library/re.rst These changes were made to rev 78277. -- keywords: +patch nosy: +rarana Added file: http://bugs.python.org/file16274/MatchObjectLinksFix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6538] MatchObject is not a hyperlink in the 're' module documentation
New submission from R. David Murray rdmur...@bitdance.com: In the re documentation MatchObject is marked up as a class, but since there's no declaration of it as a class (it's a section instead) it doesn't get turned into a hyperlink. It would be useful if it did link to the appropriate section. -- assignee: georg.brandl components: Documentation keywords: easy messages: 90776 nosy: georg.brandl, r.david.murray priority: low severity: normal stage: needs patch status: open title: MatchObject is not a hyperlink in the 're' module documentation versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6538 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
