[issue6703] cross platform failure and silly test in doctest
Éric Araujo mer...@netwok.org added the comment: The revision you linked to seems to say that Georg was the one who added this code. -- nosy: +georg.brandl versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Georg Brandl ge...@python.org added the comment: The revision you linked to seems to say that Georg was the one who added this code. Can you elaborate? Line 355 in trunk was last edited by edloper. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Éric Araujo mer...@netwok.org added the comment: I misread the Subversion viewer, it was actually PJE in r45248 (if I read correctly this time :) -- nosy: +pje ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Phillip J. Eby p...@telecommunity.com added the comment: No, I only consolidated the two copies of the code to a single function, in order to more easily add the PEP 302 support. The feature was already there. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Éric Araujo mer...@netwok.org added the comment: Patch looks good. One error and style suggestions on rietveld. -- components: +Library (Lib) nosy: +eric.araujo stage: - patch review versions: +Python 3.1 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Chris Withers ch...@simplistix.co.uk added the comment: What this patch doesn't appear to address is that there doesn't appear to be any point to module_relative. Can anyone clarify what the intention of this option is? (it doesn't appear to have any meaningful point from my experience...) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
anatoly techtonik techto...@gmail.com added the comment: Sure doctests should be crossplatform by default when possible. The patch should fix the behavior for windows. It also cleans the doc and code a bit. Can you provide some testcases? -- keywords: +patch nosy: +techtonik Added file: http://bugs.python.org/file16722/6703.silly.abspath.test.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
anatoly techtonik techto...@gmail.com added the comment: http://codereview.appspot.com/815042/show -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Chris Withers ch...@simplistix.co.uk added the comment: Hmm, I don't think tests will fail, however, there are cryptic docs for this... http://docs.python.org/library/doctest.html#basic-api I don't really get what module_relative is about and I've always run into the non- cross-platform issue above when passing an absolute path to DocFileSuite while forgetting to specify module_relative=False. The weird/frustrating thing is that the tests behave *just fine* on Windows with module_relative being the default of True and the absolute path being specified, so I'm not really sure what difference either the module_relative option or the check that the path doesn't start with a / mean... The problem is that while the docs specify that paths must be /-separated, nothing in the code enforces this. So, with module_relative as True, the default: - If you generate and pass an absolute path on Windows, it'll work just fine. - If you pass a '\\'-separated module-relative path, this will work just fine. (You'll end up with base/dir\path\you\supplied, but I doubt `open` will care about that. With module_relative set to False, I'm not really sure what happens... Anyone? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
New submission from Chris Withers ch...@simplistix.co.uk: Hi All, Line 355 of this code on the 2.6 branch and trunk: http://svn.python.org/view/python/branches/release26- maint/Lib/doctest.py?view=annotate http://svn.python.org/view/python/trunk/Lib/doctest.py?annotate=69012 ...contain a check that doesn't work cross platform. I'd argue that the check is worthless and should be removed. I'm happy to do this, but is this code tested? If not, do I need to add a test when I remove those two lines? cheers, Chris -- assignee: cjw296 messages: 91557 nosy: cjw296 severity: normal status: open title: cross platform failure and silly test in doctest versions: Python 2.6, Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6703] cross platform failure and silly test in doctest
Benjamin Peterson benja...@python.org added the comment: How about removing it and seeing if tests fail? -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6703 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
