[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Jessica McKellar added the comment: To summarize (as I understand it) the state of this ticket: * stop_serving no longer exists anywhere in the code base, so the proximal cause of the bug report from 2009 no longer exists. * the tests in test_xmlrpc currently all pass without issue. * If you tried to create a test in a subclass of BaseServerTestCase which never issues a request to the MyXMLRPCServer instance set up by http_server, it will hang. The reason is that BaseServerTestCase uses setUp and tearDown methods that force the test to coordinate a threading.Event with http_server; if no request is made to the XMLRPC server, the test will hang in tearDown waiting for the server to set the Event flag. I think this ticket could be closed because the proximal issue no longer exists. Alternatively, a docstring could be added to BaseServerTestCase saying tests in subclasses must make at least 1 request else they should live in a different TestCase, or BaseServerTestCase could be refactored to not have this constraint. -- nosy: +jesstess ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Antoine Pitrou added the comment: Indeed, this issue looks obsolete. Thanks for taking a look! -- resolution: - out of date stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- type: crash - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Changes by David Stanek dsta...@dstanek.com: -- nosy: +dstanek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
A.M. Kuchling li...@amk.ca added the comment: The stop_serving() code was only added on the Py3k branch in rev59424. It was removed in rev60350, which is a merge commit; the diff is http://svn.python.org/view/python/branches/py3k/Lib/test/test_xmlrpc.py?r1=60094r2=60350. I don't know if this is a merging error, or if the 2.x changes mean stop_serving() is no longer required. Christian Heimes was responsible for both originally adding stop_serving() and for the merge that removed it. Adding him to the nosy list. -- nosy: +akuchling, christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
R. David Murray rdmur...@bitdance.com added the comment: Having looked at this code for another reason, I suspect that the stop_serving change was an attempt to handle a possible hang in the test, and that the py2 code simply doesn't try to handle that possible hang. Note that you can simulate the hang by having a test method never issue a request. I couldn't figure out a way to get the server to stop serving, but I didn't try for too long before I gave up and used a different solution to the problem I was facing (skipping one of the tests...) -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
Kristján Valur Jónsson krist...@ccpgames.com added the comment: I can't repro on my windows box. From what I can see, for some reason the server thread isn't terminating, so we enter an errorhandling codepath that is broken. The slew of errors that follow occur when the process is exiting and the worker threads have had the carpet pulled from underneath them, as it were. We should remove the stop_serving() call, it is some rudiment of ancient code. But the real error is still hidden, whatever caused the server to not exit. If this is easily repro, maybe you can produce a traceback of the worker thread at this point? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7100 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7100] test_xmlrpc: global name 'stop_serving' is not defined
New submission from Antoine Pitrou pit...@free.fr: This happens at least on the py3k branch, I haven't checked other branches. test test_xmlrpc failed -- Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 344, in tearDown stop_serving() NameError: global name 'stop_serving' is not defined 1 test failed: test_xmlrpc Unhandled exception in thread started by bound method Thread._bootstrap of Thread(Thread-13, started 140424593951056) Error in sys.excepthook: TypeError: 'NoneType' object is not callable Original exception was: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 282, in _handle_request_noblock File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 308, in process_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 321, in finish_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 639, in __init__ File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 693, in finish File /home/antoine/py3k/bz-multistream/Lib/socket.py, line 242, in close AttributeError: 'NoneType' object has no attribute 'RawIOBase' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 294, in http_server File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 267, in handle_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 284, in _handle_request_noblock File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 340, in handle_error ImportError: No module named traceback During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 297, in http_server AttributeError: 'NoneType' object has no attribute 'timeout' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 509, in _bootstrap_inner File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 462, in run File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 300, in http_server File /home/antoine/py3k/bz-multistream/Lib/socket.py, line 178, in close File /home/antoine/py3k/bz-multistream/Lib/socket.py, line 173, in _real_close AttributeError: 'NoneType' object has no attribute 'socket' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 527, in _bootstrap_inner AttributeError: 'Thread' object has no attribute '_exc_info' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 482, in _bootstrap File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 557, in _bootstrap_inner AttributeError: __exit__ [101191 refs] 1 test failed: test_xmlrpc Unhandled exception in thread started by bound method Thread._bootstrap of Thread(Thread-13, started 140014861584720) Error in sys.excepthook: TypeError: 'NoneType' object is not callable Original exception was: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 282, in _handle_request_noblock File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 308, in process_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 321, in finish_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 639, in __init__ File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 693, in finish File /home/antoine/py3k/bz-multistream/Lib/socket.py, line 242, in close AttributeError: 'NoneType' object has no attribute 'RawIOBase' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 294, in http_server File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 267, in handle_request File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 284, in _handle_request_noblock File /home/antoine/py3k/bz-multistream/Lib/socketserver.py, line 340, in handle_error ImportError: No module named traceback During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/test/test_xmlrpc.py, line 297, in http_server AttributeError: 'NoneType' object has no attribute 'timeout' During handling of the above exception, another exception occurred: Traceback (most recent call last): File /home/antoine/py3k/bz-multistream/Lib/threading.py, line 509, in _bootstrap_inner File
