[issue7267] format method: c presentation type broken in 2.7

[Walter Dörwald]

Walter Dörwald added the comment:

Don't worry, I've switched to using Python 3 in 2012, where this isn't a 
problem. ;)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[STINNER Victor]

STINNER Victor added the comment:

Walter Dörwald added the comment:
> Don't worry, I've switched to using Python 3 in 2012, where this isn't a 
> problem. ;)

Wow, cool! We still have 1 or 2 customers stuck with Python 2, haha.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Berker Peksag]

Changes by Berker Peksag :


--
stage: commit review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Then feel free to commit your patch please. It LGTM.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2f2c52c9ff38 by Victor Stinner in branch '2.7':
Issue #7267: format(int, 'c') now raises OverflowError when the argument is not
https://hg.python.org/cpython/rev/2f2c52c9ff38

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[STINNER Victor]

STINNER Victor added the comment:

> Then feel free to commit your patch please. It LGTM.

Thanks for the review ;-)

@Walter: Sorry for the late fix (6 years later!).

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[STINNER Victor]

STINNER Victor added the comment:

> Both ways, with OverflowError and Py3k DeprecationWarning, are good to me. 
> What would you say about this Benjamin?

I prefer an OverflowError. I don't like having to enable a flag to fix a bug :-(

According to the issue title, it's really a bug: "format method: c presentation 
type *broken* in 2.7".

Note: The unit test may check the error message, currently the error message is 
irrevelant (it mentions unicode whereas bytes (str type) are used).

>>> format(-1, "c")
OverflowError: %c arg not in range(0x11) (wide Python build)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Jakub Wilk]

Changes by Jakub Wilk jw...@jwilk.net:


--
nosy: +jwilk

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a modification of Victor's patch, that just emits Py3k warning.

Both ways, with OverflowError and Py3k DeprecationWarning, are good to me. What 
would you say about this Benjamin?

--
Added file: http://bugs.python.org/file39355/int_format_c_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

May be just emit a warning in -3 mode?

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Mark Lawrence]

Mark Lawrence added the comment:

What if any harm can be done by applying the patch with Victor's work around?

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7267] format method: c presentation type broken in 2.7

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
title: format method: c presentation type broken - format method: c 
presentation type broken in 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7267
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com